From 6995c57d8ef7e9b1a11c4dbdcfa7dd9d2fc88911 Mon Sep 17 00:00:00 2001 From: Neil Fuller Date: Tue, 25 Jul 2017 13:14:32 +0100 Subject: [PATCH] Remove TODO related to WakeLocks There's no need to keep a WakeLock in the RulesManager - if the device goes to sleep it should continue the work when it wakes up again. All I/O is handled via AtomicFile and should be robust to corruption, etc. and this reduces the likelihood of issues caused by sudden sleeps. Bug: 31008728 Test: make Change-Id: I3d5076ca7d2f39076f76bdb745cedde214eac21b --- .../android/server/timezone/RulesManagerServiceHelperImpl.java | 1 - 1 file changed, 1 deletion(-) diff --git a/services/core/java/com/android/server/timezone/RulesManagerServiceHelperImpl.java b/services/core/java/com/android/server/timezone/RulesManagerServiceHelperImpl.java index b89ce1cd0f894..0cf61c0c7c5a3 100644 --- a/services/core/java/com/android/server/timezone/RulesManagerServiceHelperImpl.java +++ b/services/core/java/com/android/server/timezone/RulesManagerServiceHelperImpl.java @@ -57,7 +57,6 @@ final class RulesManagerServiceHelperImpl implements PermissionHelper, Executor return true; } - // TODO(nfuller): Wake lock required while running in background thread? @Override public void execute(Runnable runnable) { AsyncTask.execute(runnable);