From 193727f192b033dfe59826afc9b20d1411ecd837 Mon Sep 17 00:00:00 2001 From: Zoey Chen Date: Thu, 16 Sep 2021 18:59:22 +0800 Subject: [PATCH] [Provider Model] Should show "Connected" and highlight carrier layout as well if connected to W+ Bug: 200130512 Test: adb root adb shell cmd wifi network-suggestions-set-as-carrier-provider com.android.shell yes adb shell cmd wifi add-suggestion GoogleGuest-Legacy open -a -m -i 1 -c 1884 Change-Id: Idc4820a245483baf94cf9166539406043ca8dfdd --- .../qs/tiles/dialog/InternetDialog.java | 11 +++++----- .../dialog/InternetDialogController.java | 21 ++++++++++++------- 2 files changed, 20 insertions(+), 12 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/qs/tiles/dialog/InternetDialog.java b/packages/SystemUI/src/com/android/systemui/qs/tiles/dialog/InternetDialog.java index 08da68037c583..16b41a7761767 100644 --- a/packages/SystemUI/src/com/android/systemui/qs/tiles/dialog/InternetDialog.java +++ b/packages/SystemUI/src/com/android/systemui/qs/tiles/dialog/InternetDialog.java @@ -303,7 +303,8 @@ public class InternetDialog extends SystemUIDialog implements mInternetDialogSubTitle.setText(getSubtitleText()); } updateEthernet(); - setMobileDataLayout(mInternetDialogController.activeNetworkIsCellular()); + setMobileDataLayout(mInternetDialogController.activeNetworkIsCellular() + || mInternetDialogController.isCarrierNetworkActive()); if (!mCanConfigWifi) { return; @@ -355,7 +356,7 @@ public class InternetDialog extends SystemUIDialog implements mInternetDialogController.hasEthernet() ? View.VISIBLE : View.GONE); } - private void setMobileDataLayout(boolean isCellularNetwork) { + private void setMobileDataLayout(boolean isCarrierNetworkConnected) { if (mInternetDialogController.isAirplaneModeEnabled() || !mInternetDialogController.hasCarrier()) { mMobileNetworkLayout.setVisibility(View.GONE); @@ -371,13 +372,13 @@ public class InternetDialog extends SystemUIDialog implements mMobileSummaryText.setVisibility(View.GONE); } mSignalIcon.setImageDrawable(getSignalStrengthDrawable()); - mMobileTitleText.setTextAppearance(isCellularNetwork + mMobileTitleText.setTextAppearance(isCarrierNetworkConnected ? R.style.TextAppearance_InternetDialog_Active : R.style.TextAppearance_InternetDialog); - mMobileSummaryText.setTextAppearance(isCellularNetwork + mMobileSummaryText.setTextAppearance(isCarrierNetworkConnected ? R.style.TextAppearance_InternetDialog_Secondary_Active : R.style.TextAppearance_InternetDialog_Secondary); - mMobileNetworkLayout.setBackground(isCellularNetwork ? mBackgroundOn : null); + mMobileNetworkLayout.setBackground(isCarrierNetworkConnected ? mBackgroundOn : null); mMobileDataToggle.setVisibility(mCanConfigMobileData ? View.VISIBLE : View.INVISIBLE); } diff --git a/packages/SystemUI/src/com/android/systemui/qs/tiles/dialog/InternetDialogController.java b/packages/SystemUI/src/com/android/systemui/qs/tiles/dialog/InternetDialogController.java index 95d3915eb64db..66d9c5558c2f9 100644 --- a/packages/SystemUI/src/com/android/systemui/qs/tiles/dialog/InternetDialogController.java +++ b/packages/SystemUI/src/com/android/systemui/qs/tiles/dialog/InternetDialogController.java @@ -370,9 +370,12 @@ public class InternetDialogController implements WifiEntry.DisconnectCallback, drawable = shared.get(); } - drawable.setTint(activeNetworkIsCellular() ? mContext.getColor( - R.color.connected_network_primary_color) : Utils.getColorAttrDefaultColor( - mContext, android.R.attr.textColorTertiary)); + int tintColor = Utils.getColorAttrDefaultColor(mContext, + android.R.attr.textColorTertiary); + if (activeNetworkIsCellular() || isCarrierNetworkActive()) { + tintColor = mContext.getColor(R.color.connected_network_primary_color); + } + drawable.setTint(tintColor); } catch (Throwable e) { e.printStackTrace(); } @@ -533,9 +536,7 @@ public class InternetDialogController implements WifiEntry.DisconnectCallback, } int resId = mapIconSets(config).get(iconKey).dataContentDescription; - final MergedCarrierEntry mergedCarrierEntry = - mAccessPointController.getMergedCarrierEntry(); - if (mergedCarrierEntry != null && mergedCarrierEntry.isDefaultNetwork()) { + if (isCarrierNetworkActive()) { SignalIcon.MobileIconGroup carrierMergedWifiIconGroup = TelephonyIcons.CARRIER_MERGED_WIFI; resId = carrierMergedWifiIconGroup.dataContentDescription; @@ -554,7 +555,7 @@ public class InternetDialogController implements WifiEntry.DisconnectCallback, return context.getString(R.string.mobile_data_no_connection); } String summary = networkTypeDescription; - if (activeNetworkIsCellular()) { + if (activeNetworkIsCellular() || isCarrierNetworkActive()) { summary = context.getString(R.string.preference_summary_default_combination, context.getString(R.string.mobile_data_connection_active), networkTypeDescription); @@ -583,6 +584,12 @@ public class InternetDialogController implements WifiEntry.DisconnectCallback, } } + boolean isCarrierNetworkActive() { + final MergedCarrierEntry mergedCarrierEntry = + mAccessPointController.getMergedCarrierEntry(); + return mergedCarrierEntry != null && mergedCarrierEntry.isDefaultNetwork(); + } + WifiManager getWifiManager() { return mWifiManager; }