Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Not to use any() to verify DataStallDetectionStats"

Browse Source
This commit is contained in:
Treehugger Robot
2019-03-08 09:26:05 +00:00
committed by Gerrit Code Review
parent c8dfb72891 e43f162371
commit 18e931ba12
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/NetworkStack/tests/src/com/android/server/connectivity/NetworkMonitorTest.java
View File

@@ -525,7 +525,7 @@ public class NetworkMonitorTest {
wrappedMonitor.setLastProbeTime(SystemClock.elapsedRealtime() - 1000); wrappedMonitor.setLastProbeTime(SystemClock.elapsedRealtime() - 1000);
makeDnsTimeoutEvent(wrappedMonitor, 5); makeDnsTimeoutEvent(wrappedMonitor, 5);
assertTrue(wrappedMonitor.isDataStall()); assertTrue(wrappedMonitor.isDataStall());
verify(mDataStallStatsUtils, times(1)).write(any(), any()); verify(mDataStallStatsUtils, times(1)).write(makeEmptyDataStallDetectionStats(), any());
} }
@Test @Test
@@ -534,7 +534,7 @@ public class NetworkMonitorTest {
wrappedMonitor.setLastProbeTime(SystemClock.elapsedRealtime() - 1000); wrappedMonitor.setLastProbeTime(SystemClock.elapsedRealtime() - 1000);
makeDnsTimeoutEvent(wrappedMonitor, 3); makeDnsTimeoutEvent(wrappedMonitor, 3);
assertFalse(wrappedMonitor.isDataStall()); assertFalse(wrappedMonitor.isDataStall());
verify(mDataStallStatsUtils, never()).write(any(), any()); verify(mDataStallStatsUtils, never()).write(makeEmptyDataStallDetectionStats(), any());
} }
@Test @Test
@@ -586,6 +586,10 @@ public class NetworkMonitorTest {
} }
} }
private DataStallDetectionStats makeEmptyDataStallDetectionStats() {
return new DataStallDetectionStats.Builder().build();
}
private void setDataStallEvaluationType(int type) { private void setDataStallEvaluationType(int type) {
when(mDependencies.getSetting(any(), when(mDependencies.getSetting(any(),
eq(Settings.Global.DATA_STALL_EVALUATION_TYPE), anyInt())).thenReturn(type); eq(Settings.Global.DATA_STALL_EVALUATION_TYPE), anyInt())).thenReturn(type);