From 18d1255ebe83d73df34832f2197a1e51ea717b96 Mon Sep 17 00:00:00 2001 From: Romain Guy Date: Thu, 1 Oct 2009 15:39:42 -0700 Subject: [PATCH] Prevents memory leaks by correctly detaching views in AbsListView. AbsListView can reject views from the recycler's scrap heap but when that happens the rejected view is not detached from the parent. This can be pretty bad in the case of TextView since it prevents them from unregistering their OnPreDrawListeners. --- core/java/android/widget/AbsListView.java | 1 + 1 file changed, 1 insertion(+) diff --git a/core/java/android/widget/AbsListView.java b/core/java/android/widget/AbsListView.java index 165794aec3d4f..5991ad4948d1d 100644 --- a/core/java/android/widget/AbsListView.java +++ b/core/java/android/widget/AbsListView.java @@ -3560,6 +3560,7 @@ public abstract class AbsListView extends AdapterView implements Te // into the scrap heap int viewType = lp.viewType; if (!shouldRecycleViewType(viewType)) { + removeDetachedView(scrap, false); return; }