From 67a4b3714862f13396ce9f34bb0a3b31e8d0021c Mon Sep 17 00:00:00 2001 From: Julia Reynolds Date: Wed, 17 Mar 2021 13:31:02 -0400 Subject: [PATCH 1/2] Fix contrast issues in channel blocking ui Test: manual Fixes: 181879902 Change-Id: Icc3dd9598bb3669afe5c0136b2dd85ec8b90d283 --- packages/SystemUI/res/layout/notif_half_shelf.xml | 6 +++--- packages/SystemUI/res/layout/notif_half_shelf_row.xml | 4 ++-- packages/SystemUI/res/values/colors.xml | 2 -- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/packages/SystemUI/res/layout/notif_half_shelf.xml b/packages/SystemUI/res/layout/notif_half_shelf.xml index d36c1a8c961b4..42f14f30da004 100644 --- a/packages/SystemUI/res/layout/notif_half_shelf.xml +++ b/packages/SystemUI/res/layout/notif_half_shelf.xml @@ -67,7 +67,7 @@ android:textSize="15sp" android:ellipsize="end" android:maxLines="1" - style="@style/TextAppearance.NotificationInfo.Title" /> + style="@style/TextAppearance.NotificationImportanceChannel" /> @@ -90,7 +90,7 @@ diff --git a/packages/SystemUI/res/values/colors.xml b/packages/SystemUI/res/values/colors.xml index d4783197e1f17..55365bd3c6924 100644 --- a/packages/SystemUI/res/values/colors.xml +++ b/packages/SystemUI/res/values/colors.xml @@ -115,8 +115,6 @@ @color/GM2_grey_900 @color/GM2_grey_700 - - @color/GM2_grey_200 #ffffff From 039f924455de5b398ddf2fa147116291cdf0db26 Mon Sep 17 00:00:00 2001 From: Julia Reynolds Date: Wed, 17 Mar 2021 15:37:23 -0400 Subject: [PATCH 2/2] Add an intdef Test: make Fixes: 176822079 Change-Id: I5a807bbbb89a7bd07d7d46c792b9e2199201713a --- core/java/android/app/Notification.java | 11 +++++++++++ .../notification/NotificationListenerService.java | 3 ++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/core/java/android/app/Notification.java b/core/java/android/app/Notification.java index a3a8a5e6c651d..9dcb23711a52f 100644 --- a/core/java/android/app/Notification.java +++ b/core/java/android/app/Notification.java @@ -822,6 +822,17 @@ public class Notification implements Parcelable */ public static final int VISIBILITY_SECRET = -1; + /** + * @hide + */ + @IntDef(prefix = "VISIBILITY_", value = { + VISIBILITY_PUBLIC, + VISIBILITY_PRIVATE, + VISIBILITY_SECRET, + NotificationManager.VISIBILITY_NO_OVERRIDE + }) + public @interface NotificationVisibilityOverride{}; + /** * Notification category: incoming call (voice or video) or similar synchronous communication request. */ diff --git a/core/java/android/service/notification/NotificationListenerService.java b/core/java/android/service/notification/NotificationListenerService.java index 7aa5bbc930fbc..bf5f24d17f8ad 100644 --- a/core/java/android/service/notification/NotificationListenerService.java +++ b/core/java/android/service/notification/NotificationListenerService.java @@ -1786,7 +1786,8 @@ public abstract class NotificationListenerService extends Service { * {@link NotificationListenerService.Ranking#VISIBILITY_NO_OVERRIDE} if * no such preference has been expressed. */ - public int getLockscreenVisibilityOverride() { + public @Notification.NotificationVisibilityOverride + int getLockscreenVisibilityOverride() { return mVisibilityOverride; }