From 1778037875b8d84d9c76e8cdcfa16d56e1922a65 Mon Sep 17 00:00:00 2001 From: Wilson Wu Date: Wed, 30 Dec 2020 16:25:25 +0800 Subject: [PATCH] Add HIDE_REMOVE_CLIENT into InputMethodDebug CL [1] introduced the HIDE_REMOVE_CLIENT reason in SoftInputShowHideReason. Add this reason into InputMethodDebug to avoid dump unknown reason unexpectedly. [1]: Ifb91111f7136952462678ff6d0a5e917abb5005e Bug: 167780081 Test: atest InputMethodDebugTest Change-Id: I23a8deea66600e3e31bdcb5fbf8fb87d91c57e4d --- .../android/internal/inputmethod/InputMethodDebug.java | 2 ++ .../internal/inputmethod/InputMethodDebugTest.java | 8 ++++++++ 2 files changed, 10 insertions(+) diff --git a/core/java/com/android/internal/inputmethod/InputMethodDebug.java b/core/java/com/android/internal/inputmethod/InputMethodDebug.java index 3bcba75ec1632..c353de88dc3b3 100644 --- a/core/java/com/android/internal/inputmethod/InputMethodDebug.java +++ b/core/java/com/android/internal/inputmethod/InputMethodDebug.java @@ -226,6 +226,8 @@ public final class InputMethodDebug { return "HIDE_RECENTS_ANIMATION"; case SoftInputShowHideReason.HIDE_SAME_WINDOW_FOCUSED_WITHOUT_EDITOR: return "HIDE_SAME_WINDOW_FOCUSED_WITHOUT_EDITOR"; + case SoftInputShowHideReason.HIDE_REMOVE_CLIENT: + return "HIDE_REMOVE_CLIENT"; default: return "Unknown=" + reason; } diff --git a/core/tests/coretests/src/com/android/internal/inputmethod/InputMethodDebugTest.java b/core/tests/coretests/src/com/android/internal/inputmethod/InputMethodDebugTest.java index 222e494de7d40..32bfdcb7b2174 100644 --- a/core/tests/coretests/src/com/android/internal/inputmethod/InputMethodDebugTest.java +++ b/core/tests/coretests/src/com/android/internal/inputmethod/InputMethodDebugTest.java @@ -65,4 +65,12 @@ public class InputMethodDebugTest { InputMethodDebug.startInputFlagsToString( StartInputFlags.VIEW_HAS_FOCUS | StartInputFlags.INITIAL_CONNECTION)); } + + @Test + public void testSoftInputDisplayReasonToString() { + // TODO: add more tests + assertEquals("HIDE_REMOVE_CLIENT", + InputMethodDebug.softInputDisplayReasonToString( + SoftInputShowHideReason.HIDE_REMOVE_CLIENT)); + } }