From f2ef7ed2a789b951fa9115e406b9ea3d6456bfc5 Mon Sep 17 00:00:00 2001 From: Atneya Nair Date: Mon, 8 May 2023 18:43:11 -0700 Subject: [PATCH] Check dump permission in STService Add permission check to dump method. Bug: 280564817 Test: android.security.cts.ServicePermissionsTest#testDumpProtected Change-Id: I6e588f78625908b5150a5498656e496a5068d395 --- .../com/android/server/soundtrigger/SoundTriggerService.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/services/voiceinteraction/java/com/android/server/soundtrigger/SoundTriggerService.java b/services/voiceinteraction/java/com/android/server/soundtrigger/SoundTriggerService.java index a675248870869..3553a5ace311c 100644 --- a/services/voiceinteraction/java/com/android/server/soundtrigger/SoundTriggerService.java +++ b/services/voiceinteraction/java/com/android/server/soundtrigger/SoundTriggerService.java @@ -99,6 +99,7 @@ import android.util.Slog; import com.android.internal.annotations.GuardedBy; import com.android.internal.app.ISoundTriggerService; import com.android.internal.app.ISoundTriggerSession; +import com.android.internal.util.DumpUtils; import com.android.server.SoundTriggerInternal; import com.android.server.SystemService; import com.android.server.soundtrigger.SoundTriggerEvent.ServiceEvent; @@ -424,6 +425,7 @@ public class SoundTriggerService extends SystemService { @Override public void dump(FileDescriptor fd, PrintWriter pw, String[] args) { + if (!DumpUtils.checkDumpPermission(mContext, TAG, pw)) return; // Event loggers pw.println("##Service-Wide logs:"); mServiceEventLogger.dump(pw, /* indent = */ " ");