From 3c00afba0b24adfb1678188650e8e60705be7a33 Mon Sep 17 00:00:00 2001 From: Doris Ling Date: Tue, 19 Jul 2016 17:04:21 -0700 Subject: [PATCH] Add metrics logging for fingerprint swipe for notification panel. Add metrics log when fingerprint swipe to expand/collapse notification panel is handled, and increment the notification and quick setting open count correspondingly. Bug: 29257528 Change-Id: Ic24c6463a4400711874602157e2fcadc7f0f6da6 --- .../systemui/statusbar/phone/NotificationPanelView.java | 4 ++-- .../android/systemui/statusbar/phone/PhoneStatusBar.java | 4 ++++ proto/src/metrics_constants.proto | 6 ++++++ 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelView.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelView.java index 64f205d2d8f8f..768e5f2b2f233 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelView.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelView.java @@ -81,8 +81,8 @@ public class NotificationPanelView extends PanelView implements private static final float LOCK_ICON_ACTIVE_SCALE = 1.2f; - private static final String COUNTER_PANEL_OPEN = "panel_open"; - private static final String COUNTER_PANEL_OPEN_QS = "panel_open_qs"; + static final String COUNTER_PANEL_OPEN = "panel_open"; + static final String COUNTER_PANEL_OPEN_QS = "panel_open_qs"; private static final String COUNTER_PANEL_OPEN_PEEK = "panel_open_peek"; private static final Rect mDummyDirtyRect = new Rect(0, 0, 1, 1); diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/PhoneStatusBar.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/PhoneStatusBar.java index b623f19b5ccb3..c70312814eed0 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/PhoneStatusBar.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/PhoneStatusBar.java @@ -2628,12 +2628,16 @@ public class PhoneStatusBar extends BaseStatusBar implements DemoMode, if (!mUserSetup) return; if (KeyEvent.KEYCODE_SYSTEM_NAVIGATION_UP == key) { + MetricsLogger.action(mContext, MetricsEvent.ACTION_SYSTEM_NAVIGATION_KEY_UP); mNotificationPanel.collapse(false /* delayed */, 1.0f /* speedUpFactor */); } else if (KeyEvent.KEYCODE_SYSTEM_NAVIGATION_DOWN == key) { + MetricsLogger.action(mContext, MetricsEvent.ACTION_SYSTEM_NAVIGATION_KEY_DOWN); if (mNotificationPanel.isFullyCollapsed()) { mNotificationPanel.expand(true /* animate */); + MetricsLogger.count(mContext, NotificationPanelView.COUNTER_PANEL_OPEN, 1); } else if (!mNotificationPanel.isInSettings() && !mNotificationPanel.isExpanding()){ mNotificationPanel.flingSettings(0 /* velocity */, true /* expand */); + MetricsLogger.count(mContext, NotificationPanelView.COUNTER_PANEL_OPEN_QS, 1); } } diff --git a/proto/src/metrics_constants.proto b/proto/src/metrics_constants.proto index 0106f7f030237..d9f2bac41343a 100644 --- a/proto/src/metrics_constants.proto +++ b/proto/src/metrics_constants.proto @@ -2197,6 +2197,12 @@ message MetricsEvent { // Night Light on SETTINGS_CONDITION_NIGHT_DISPLAY = 492; + // System navigation key up. + ACTION_SYSTEM_NAVIGATION_KEY_UP = 493; + + // System navigation key down. + ACTION_SYSTEM_NAVIGATION_KEY_DOWN = 494; + // ---- End N-MR1 Constants, all N-MR1 constants go above this line ---- // Add new aosp constants above this line. // END OF AOSP CONSTANTS