From 0799bd07d780141208be7826491b221506e66160 Mon Sep 17 00:00:00 2001 From: Sungsoo Lim Date: Mon, 4 Apr 2016 10:09:30 +0900 Subject: [PATCH] MediaBrowser: Make EXTRA_PAGE zero-based Bug: 27948393 Change-Id: I97fb6b5f13ffb8e006ed4a7efc06e7f45fb5121a --- media/java/android/media/browse/MediaBrowser.java | 2 +- media/java/android/media/browse/MediaBrowserUtils.java | 4 ++-- media/java/android/service/media/MediaBrowserService.java | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/media/java/android/media/browse/MediaBrowser.java b/media/java/android/media/browse/MediaBrowser.java index c1805cb5713fb..7c6adadc2c6a3 100644 --- a/media/java/android/media/browse/MediaBrowser.java +++ b/media/java/android/media/browse/MediaBrowser.java @@ -72,7 +72,7 @@ public final class MediaBrowser { /** * Used as an int extra field to denote the page number to subscribe. - * The value of {@code EXTRA_PAGE} should be greater than or equal to 1. + * The value of {@code EXTRA_PAGE} should be greater than or equal to 0. * * @see #EXTRA_PAGE_SIZE */ diff --git a/media/java/android/media/browse/MediaBrowserUtils.java b/media/java/android/media/browse/MediaBrowserUtils.java index b06e598a63d1a..2943e60dbbbd8 100644 --- a/media/java/android/media/browse/MediaBrowserUtils.java +++ b/media/java/android/media/browse/MediaBrowserUtils.java @@ -50,7 +50,7 @@ public class MediaBrowserUtils { startIndex1 = 0; endIndex1 = Integer.MAX_VALUE; } else { - startIndex1 = pageSize1 * (page1 - 1); + startIndex1 = pageSize1 * page1; endIndex1 = startIndex1 + pageSize1 - 1; } @@ -58,7 +58,7 @@ public class MediaBrowserUtils { startIndex2 = 0; endIndex2 = Integer.MAX_VALUE; } else { - startIndex2 = pageSize2 * (page2 - 1); + startIndex2 = pageSize2 * page2; endIndex2 = startIndex2 + pageSize2 - 1; } diff --git a/media/java/android/service/media/MediaBrowserService.java b/media/java/android/service/media/MediaBrowserService.java index ae8663269bd3a..6954045574a5a 100644 --- a/media/java/android/service/media/MediaBrowserService.java +++ b/media/java/android/service/media/MediaBrowserService.java @@ -657,9 +657,9 @@ public abstract class MediaBrowserService extends Service { if (page == -1 && pageSize == -1) { return list; } - int fromIndex = pageSize * (page - 1); + int fromIndex = pageSize * page; int toIndex = fromIndex + pageSize; - if (page < 1 || pageSize < 1 || fromIndex >= list.size()) { + if (page < 0 || pageSize < 1 || fromIndex >= list.size()) { return Collections.EMPTY_LIST; } if (toIndex > list.size()) {