From f28a557d244a4fc4b032bb8b78d803d41ad67b05 Mon Sep 17 00:00:00 2001 From: Arindam Mondal Date: Fri, 3 Mar 2023 08:05:44 +0000 Subject: [PATCH] Revert "ChangeReporter: disable eager reporting" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 131354becde826780b8eeff7f745d44189878e1b. Reason for revert: “DroidMonitor: Potential culprit for Bug b/271512785 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.”. Change-Id: I6e857a07ebd5c0305472b6832c45ae75017a8744 --- .../android/internal/compat/ChangeReporter.java | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/core/java/com/android/internal/compat/ChangeReporter.java b/core/java/com/android/internal/compat/ChangeReporter.java index 8369a303889df..b9d3df678a91f 100644 --- a/core/java/com/android/internal/compat/ChangeReporter.java +++ b/core/java/com/android/internal/compat/ChangeReporter.java @@ -42,7 +42,6 @@ import java.util.Set; public final class ChangeReporter { private static final String TAG = "CompatibilityChangeReporter"; private int mSource; - private static final boolean sShouldReport = false; private static final class ChangeReport { long mChangeId; @@ -90,16 +89,14 @@ public final class ChangeReporter { * @param state of the reported change - enabled/disabled/only logged */ public void reportChange(int uid, long changeId, int state) { - if (sShouldReport) { - if (shouldWriteToStatsLog(uid, changeId, state)) { - FrameworkStatsLog.write(FrameworkStatsLog.APP_COMPATIBILITY_CHANGE_REPORTED, uid, - changeId, state, mSource); - } - if (shouldWriteToDebug(uid, changeId, state)) { - debugLog(uid, changeId, state); - } - markAsReported(uid, new ChangeReport(changeId, state)); + if (shouldWriteToStatsLog(uid, changeId, state)) { + FrameworkStatsLog.write(FrameworkStatsLog.APP_COMPATIBILITY_CHANGE_REPORTED, uid, + changeId, state, mSource); } + if (shouldWriteToDebug(uid, changeId, state)) { + debugLog(uid, changeId, state); + } + markAsReported(uid, new ChangeReport(changeId, state)); } /**