Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Added documentation to note onDisconnected() should not make calls to their respective managers." into qt-dev

Browse Source
This commit is contained in:
Adam He
2019-04-09 17:37:07 +00:00
committed by Android (Google) Code Review
parent f4cd9daf58 5023abdf30
commit 168f7e48ac
3 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/java/android/service/autofill/AutofillService.java
View File

@@ -674,6 +674,8 @@ public abstract class AutofillService extends Service {
* Called when the Android system disconnects from the service. * Called when the Android system disconnects from the service.
* *
* <p> At this point this service may no longer be an active {@link AutofillService}. * <p> At this point this service may no longer be an active {@link AutofillService}.
* It should not make calls on {@link AutofillManager} that requires the caller to be
* the current service.
*/ */
public void onDisconnected() { public void onDisconnected() {
} }

3
core/java/android/service/autofill/augmented/AugmentedAutofillService.java
View File

@@ -41,6 +41,7 @@ import android.util.Slog;
import android.util.SparseArray; import android.util.SparseArray;
import android.util.TimeUtils; import android.util.TimeUtils;
import android.view.autofill.AutofillId; import android.view.autofill.AutofillId;
import android.view.autofill.AutofillManager;
import android.view.autofill.AutofillValue; import android.view.autofill.AutofillValue;
import android.view.autofill.IAugmentedAutofillManagerClient; import android.view.autofill.IAugmentedAutofillManagerClient;
import android.view.autofill.IAutofillWindowPresenter; import android.view.autofill.IAutofillWindowPresenter;
@@ -183,6 +184,8 @@ public abstract class AugmentedAutofillService extends Service {
* Called when the Android system disconnects from the service. * Called when the Android system disconnects from the service.
* *
* <p> At this point this service may no longer be an active {@link AugmentedAutofillService}. * <p> At this point this service may no longer be an active {@link AugmentedAutofillService}.
* It should not make calls on {@link AutofillManager} that requires the caller to be
* the current service.
*/ */
public void onDisconnected() { public void onDisconnected() {
} }

5
core/java/android/service/contentcapture/ContentCaptureService.java
View File

@@ -37,7 +37,6 @@ import android.os.Handler;
import android.os.IBinder; import android.os.IBinder;
import android.os.Looper; import android.os.Looper;
import android.os.RemoteException; import android.os.RemoteException;
import android.service.autofill.AutofillService;
import android.util.Log; import android.util.Log;
import android.util.Slog; import android.util.Slog;
import android.util.SparseIntArray; import android.util.SparseIntArray;
@@ -350,7 +349,9 @@ public abstract class ContentCaptureService extends Service {
/** /**
* Called when the Android system disconnects from the service. * Called when the Android system disconnects from the service.
* *
* <p> At this point this service may no longer be an active {@link AutofillService}. * <p> At this point this service may no longer be an active {@link ContentCaptureService}.
* It should not make calls on {@link ContentCaptureManager} that requires the caller to be
* the current service.
*/ */
public void onDisconnected() { public void onDisconnected() {
Slog.i(TAG, "unbinding from " + getClass().getName()); Slog.i(TAG, "unbinding from " + getClass().getName());