Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix stack-use-after-scope for a std::string"

Browse Source
This commit is contained in:
Treehugger Robot
2022-10-06 18:42:29 +00:00
committed by Gerrit Code Review
parent ac46d9b163 d0ac4e1a0d
commit 165a7640cf
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tools/aapt2/ResourceUtils.cpp
View File

@@ -51,8 +51,10 @@ std::optional<ResourceName> ToResourceName(const android::ResTable::resource_nam
util::Utf16ToUtf8(StringPiece16(name_in.package, name_in.packageLen)); util::Utf16ToUtf8(StringPiece16(name_in.package, name_in.packageLen));
std::optional<ResourceNamedTypeRef> type; std::optional<ResourceNamedTypeRef> type;
std::string converted;
if (name_in.type) { if (name_in.type) {
type = ParseResourceNamedType(util::Utf16ToUtf8(StringPiece16(name_in.type, name_in.typeLen))); converted = util::Utf16ToUtf8(StringPiece16(name_in.type, name_in.typeLen));
type = ParseResourceNamedType(converted);
} else if (name_in.type8) { } else if (name_in.type8) {
type = ParseResourceNamedType(StringPiece(name_in.type8, name_in.typeLen)); type = ParseResourceNamedType(StringPiece(name_in.type8, name_in.typeLen));
} else { } else {
@@ -85,9 +87,10 @@ std::optional<ResourceName> ToResourceName(const android::AssetManager2::Resourc
name_out.package = std::string(name_in.package, name_in.package_len); name_out.package = std::string(name_in.package, name_in.package_len);
std::optional<ResourceNamedTypeRef> type; std::optional<ResourceNamedTypeRef> type;
std::string converted;
if (name_in.type16) { if (name_in.type16) {
type = converted = util::Utf16ToUtf8(StringPiece16(name_in.type16, name_in.type_len));
ParseResourceNamedType(util::Utf16ToUtf8(StringPiece16(name_in.type16, name_in.type_len))); type = ParseResourceNamedType(converted);
} else if (name_in.type) { } else if (name_in.type) {
type = ParseResourceNamedType(StringPiece(name_in.type, name_in.type_len)); type = ParseResourceNamedType(StringPiece(name_in.type, name_in.type_len));
} else { } else {