Merge "Fix pushing null queue update" into tm-dev am: 963dabe7fe

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/16976024

Change-Id: I4e6d24cd3db595732364c6fc67c06b2415a0bf8b
This commit is contained in:
Oliver Woodman
2022-02-22 18:09:22 +00:00
committed by Automerger Merge Worker

View File

@@ -647,18 +647,17 @@ public class MediaSessionRecord implements IBinder.DeathRecipient, MediaSessionR
if (mDestroyed) { if (mDestroyed) {
return; return;
} }
toSend = new ArrayList<>(); toSend = mQueue == null ? null : new ArrayList<>(mQueue);
if (mQueue != null) {
toSend.ensureCapacity(mQueue.size());
toSend.addAll(mQueue);
}
} }
Collection<ISessionControllerCallbackHolder> deadCallbackHolders = null; Collection<ISessionControllerCallbackHolder> deadCallbackHolders = null;
for (ISessionControllerCallbackHolder holder : mControllerCallbackHolders) { for (ISessionControllerCallbackHolder holder : mControllerCallbackHolders) {
ParceledListSlice<QueueItem> parcelableQueue = new ParceledListSlice<>(toSend); ParceledListSlice<QueueItem> parcelableQueue = null;
// Limit the size of initial Parcel to prevent binder buffer overflow if (toSend != null) {
// as onQueueChanged is an async binder call. parcelableQueue = new ParceledListSlice<>(toSend);
parcelableQueue.setInlineCountLimit(1); // Limit the size of initial Parcel to prevent binder buffer overflow
// as onQueueChanged is an async binder call.
parcelableQueue.setInlineCountLimit(1);
}
try { try {
holder.mCallback.onQueueChanged(parcelableQueue); holder.mCallback.onQueueChanged(parcelableQueue);