From 14e224d5f7f2d150d25a9f09a2de9936bb20e137 Mon Sep 17 00:00:00 2001
From: Matt Pietal <mpietal@google.com>
Date: Wed, 12 May 2021 10:09:32 -0400
Subject: [PATCH] SIM PIN spacing issues

For large display settings, text began overlapping with the limited
vertical space. Reduce spacing for SIM PIN views to fit everything in.

Fixes: 186857845
Test: largest font/display size with locked SIM
Change-Id: I678ced91dd55c84e194e37e22a3a56b53e78f2eb
---
 .../res-keyguard/layout/keyguard_emergency_carrier_area.xml    | 2 +-
 packages/SystemUI/res-keyguard/layout/keyguard_pin_view.xml    | 1 +
 .../SystemUI/res-keyguard/layout/keyguard_sim_pin_view.xml     | 3 ++-
 .../SystemUI/res-keyguard/layout/keyguard_sim_puk_view.xml     | 3 ++-
 4 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/packages/SystemUI/res-keyguard/layout/keyguard_emergency_carrier_area.xml b/packages/SystemUI/res-keyguard/layout/keyguard_emergency_carrier_area.xml
index 0ee1b694432da..8bb78775e727f 100644
--- a/packages/SystemUI/res-keyguard/layout/keyguard_emergency_carrier_area.xml
+++ b/packages/SystemUI/res-keyguard/layout/keyguard_emergency_carrier_area.xml
@@ -26,6 +26,7 @@
     android:orientation="vertical"
     android:gravity="center"
     android:layout_gravity="center_horizontal"
+    android:layout_marginBottom="12dp"
     android:layout_alignParentBottom="true">
 
     <com.android.keyguard.CarrierText
@@ -44,7 +45,6 @@
         android:id="@+id/emergency_call_button"
         android:layout_width="wrap_content"
         android:layout_height="48dp"
-        android:layout_marginBottom="12dp"
         android:text="@*android:string/lockscreen_emergency_call"
         style="@style/Keyguard.TextView.EmergencyButton" />
 
diff --git a/packages/SystemUI/res-keyguard/layout/keyguard_pin_view.xml b/packages/SystemUI/res-keyguard/layout/keyguard_pin_view.xml
index c64afd307f238..a957df6537ff3 100644
--- a/packages/SystemUI/res-keyguard/layout/keyguard_pin_view.xml
+++ b/packages/SystemUI/res-keyguard/layout/keyguard_pin_view.xml
@@ -192,6 +192,7 @@
              android:orientation="vertical"
              android:layout_gravity="bottom|center_horizontal"
              android:layout_marginTop="@dimen/keyguard_eca_top_margin"
+             android:layout_marginBottom="12dp"
              android:gravity="center_horizontal"/>
 
 </com.android.keyguard.KeyguardPINView>
diff --git a/packages/SystemUI/res-keyguard/layout/keyguard_sim_pin_view.xml b/packages/SystemUI/res-keyguard/layout/keyguard_sim_pin_view.xml
index 297c20ef8d6d6..3e34e4b255eb6 100644
--- a/packages/SystemUI/res-keyguard/layout/keyguard_sim_pin_view.xml
+++ b/packages/SystemUI/res-keyguard/layout/keyguard_sim_pin_view.xml
@@ -57,7 +57,7 @@
                 android:id="@+id/row0"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
-                android:paddingBottom="16dp"
+                android:paddingBottom="4dp"
                 >
             <com.android.keyguard.PasswordTextView
                     android:id="@+id/simPinEntry"
@@ -202,6 +202,7 @@
              android:orientation="vertical"
              android:layout_gravity="bottom|center_horizontal"
              android:layout_marginTop="@dimen/keyguard_eca_top_margin"
+             android:layout_marginBottom="2dp"
              android:gravity="center_horizontal"/>
 
 </com.android.keyguard.KeyguardSimPinView>
diff --git a/packages/SystemUI/res-keyguard/layout/keyguard_sim_puk_view.xml b/packages/SystemUI/res-keyguard/layout/keyguard_sim_puk_view.xml
index 388919e6d81cd..d5510e90af290 100644
--- a/packages/SystemUI/res-keyguard/layout/keyguard_sim_puk_view.xml
+++ b/packages/SystemUI/res-keyguard/layout/keyguard_sim_puk_view.xml
@@ -58,7 +58,7 @@
                 android:id="@+id/row0"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
-                android:paddingBottom="16dp"
+                android:paddingBottom="4dp"
                 >
             <com.android.keyguard.PasswordTextView
                     android:id="@+id/pukEntry"
@@ -204,5 +204,6 @@
              android:orientation="vertical"
              android:layout_gravity="bottom|center_horizontal"
              android:layout_marginTop="@dimen/keyguard_eca_top_margin"
+             android:layout_marginBottom="2dp"
              android:gravity="center_horizontal"/>
 </com.android.keyguard.KeyguardSimPukView>