From 14c9d2d0df7fab2b0470c3c404f600d87d4f0f93 Mon Sep 17 00:00:00 2001 From: Michal Karpinski Date: Tue, 27 Sep 2016 17:13:57 +0100 Subject: [PATCH] Extending DNS event reporting This adds hostname, array of addresses, total count of IP addresses and uid to the existing pipeline. Currently ignores the new data it receives, further work will be done in the subsequent CLs. Test: for now just the benchmarking, in the future unit and CTS Bug: 29748723 Change-Id: Ice7db208282934e74f0e1808ffbae96d476c4216 --- .../android/server/connectivity/NetdEventListenerService.java | 4 +++- .../server/connectivity/NetdEventListenerServiceTest.java | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/services/core/java/com/android/server/connectivity/NetdEventListenerService.java b/services/core/java/com/android/server/connectivity/NetdEventListenerService.java index e7198d3e7ee3d..719cde271e84c 100644 --- a/services/core/java/com/android/server/connectivity/NetdEventListenerService.java +++ b/services/core/java/com/android/server/connectivity/NetdEventListenerService.java @@ -134,7 +134,9 @@ public class NetdEventListenerService extends INetdEventListener.Stub { @Override // Called concurrently by multiple binder threads. - public synchronized void onDnsEvent(int netId, int eventType, int returnCode, int latencyMs) { + // This method must not block or perform long-running operations. + public synchronized void onDnsEvent(int netId, int eventType, int returnCode, int latencyMs, + String hostname, String[] ipAddresses, int ipAddressesCount, int uid) { maybeVerboseLog(String.format("onDnsEvent(%d, %d, %d, %d)", netId, eventType, returnCode, latencyMs)); diff --git a/services/tests/servicestests/src/com/android/server/connectivity/NetdEventListenerServiceTest.java b/services/tests/servicestests/src/com/android/server/connectivity/NetdEventListenerServiceTest.java index 63d5d9fbd919e..9e2fd6231ba9d 100644 --- a/services/tests/servicestests/src/com/android/server/connectivity/NetdEventListenerServiceTest.java +++ b/services/tests/servicestests/src/com/android/server/connectivity/NetdEventListenerServiceTest.java @@ -158,7 +158,8 @@ public class NetdEventListenerServiceTest extends TestCase { void log(int netId, int[] latencies) { for (int l : latencies) { - mNetdEventListenerService.onDnsEvent(netId, EVENT_TYPE, RETURN_CODE, l); + mNetdEventListenerService.onDnsEvent(netId, EVENT_TYPE, RETURN_CODE, l, null, null, 0, + 0); } }