Merge "Rename getDisplayAssignedToUser() to getMainDisplayAssignedToUser()." into udc-dev

This commit is contained in:
BK Choi
2023-03-22 21:47:54 +00:00
committed by Android (Google) Code Review
8 changed files with 21 additions and 22 deletions

View File

@@ -2251,7 +2251,7 @@ package android.os {
method @Nullable @RequiresPermission(anyOf={android.Manifest.permission.MANAGE_USERS, android.Manifest.permission.CREATE_USERS}) public android.content.pm.UserInfo createRestrictedProfile(@Nullable String); method @Nullable @RequiresPermission(anyOf={android.Manifest.permission.MANAGE_USERS, android.Manifest.permission.CREATE_USERS}) public android.content.pm.UserInfo createRestrictedProfile(@Nullable String);
method @Nullable @RequiresPermission(anyOf={android.Manifest.permission.MANAGE_USERS, android.Manifest.permission.CREATE_USERS}) public android.content.pm.UserInfo createUser(@Nullable String, @NonNull String, int); method @Nullable @RequiresPermission(anyOf={android.Manifest.permission.MANAGE_USERS, android.Manifest.permission.CREATE_USERS}) public android.content.pm.UserInfo createUser(@Nullable String, @NonNull String, int);
method @NonNull @RequiresPermission(anyOf={android.Manifest.permission.MANAGE_USERS, android.Manifest.permission.CREATE_USERS}) public android.os.UserHandle getBootUser(); method @NonNull @RequiresPermission(anyOf={android.Manifest.permission.MANAGE_USERS, android.Manifest.permission.CREATE_USERS}) public android.os.UserHandle getBootUser();
method public int getDisplayIdAssignedToUser(); method public int getMainDisplayIdAssignedToUser();
method @Nullable @RequiresPermission(anyOf={android.Manifest.permission.MANAGE_USERS, android.Manifest.permission.CREATE_USERS}) public java.util.Set<java.lang.String> getPreInstallableSystemPackages(@NonNull String); method @Nullable @RequiresPermission(anyOf={android.Manifest.permission.MANAGE_USERS, android.Manifest.permission.CREATE_USERS}) public java.util.Set<java.lang.String> getPreInstallableSystemPackages(@NonNull String);
method @NonNull @RequiresPermission(anyOf={android.Manifest.permission.MANAGE_USERS, android.Manifest.permission.CREATE_USERS, android.Manifest.permission.QUERY_USERS}) public String getUserType(); method @NonNull @RequiresPermission(anyOf={android.Manifest.permission.MANAGE_USERS, android.Manifest.permission.CREATE_USERS, android.Manifest.permission.QUERY_USERS}) public String getUserType();
method @NonNull @RequiresPermission(anyOf={android.Manifest.permission.MANAGE_USERS, android.Manifest.permission.CREATE_USERS}) public java.util.List<android.content.pm.UserInfo> getUsers(boolean, boolean, boolean); method @NonNull @RequiresPermission(anyOf={android.Manifest.permission.MANAGE_USERS, android.Manifest.permission.CREATE_USERS}) public java.util.List<android.content.pm.UserInfo> getUsers(boolean, boolean, boolean);

View File

@@ -1151,7 +1151,7 @@ public class Instrumentation {
} }
UserManager userManager = mInstrContext.getSystemService(UserManager.class); UserManager userManager = mInstrContext.getSystemService(UserManager.class);
int userDisplayId = userManager.getDisplayIdAssignedToUser(); int userDisplayId = userManager.getMainDisplayIdAssignedToUser();
if (VERBOSE) { if (VERBOSE) {
Log.v(TAG, "setDisplayIfNeeded(" + event + "): eventDisplayId=" + eventDisplayId Log.v(TAG, "setDisplayIfNeeded(" + event + "): eventDisplayId=" + eventDisplayId
+ ", user=" + mInstrContext.getUser() + ", userDisplayId=" + userDisplayId); + ", user=" + mInstrContext.getUser() + ", userDisplayId=" + userDisplayId);

View File

@@ -134,7 +134,7 @@ interface IUserManager {
boolean isUserForeground(int userId); boolean isUserForeground(int userId);
boolean isUserVisible(int userId); boolean isUserVisible(int userId);
int[] getVisibleUsers(); int[] getVisibleUsers();
int getDisplayIdAssignedToUser(); int getMainDisplayIdAssignedToUser();
boolean isUserNameSet(int userId); boolean isUserNameSet(int userId);
boolean hasRestrictedProfiles(int userId); boolean hasRestrictedProfiles(int userId);
boolean requestQuietModeEnabled(String callingPackage, boolean enableQuietMode, int userId, in IntentSender target, int flags); boolean requestQuietModeEnabled(String callingPackage, boolean enableQuietMode, int userId, in IntentSender target, int flags);

View File

@@ -3056,14 +3056,14 @@ public class UserManager {
} }
/** /**
* See {@link com.android.server.pm.UserManagerInternal#getDisplayAssignedToUser(int)}. * See {@link com.android.server.pm.UserManagerInternal#getMainDisplayAssignedToUser(int)}.
* *
* @hide * @hide
*/ */
@TestApi @TestApi
public int getDisplayIdAssignedToUser() { public int getMainDisplayIdAssignedToUser() {
try { try {
return mService.getDisplayIdAssignedToUser(); return mService.getMainDisplayIdAssignedToUser();
} catch (RemoteException re) { } catch (RemoteException re) {
throw re.rethrowFromSystemServer(); throw re.rethrowFromSystemServer();
} }

View File

@@ -506,15 +506,14 @@ public abstract class UserManagerInternal {
* *
* <p>If the user is a profile and is running, it's assigned to its parent display. * <p>If the user is a profile and is running, it's assigned to its parent display.
*/ */
// TODO(b/272366483) rename this method to avoid confusion with getDisplaysAssignedTOUser(). public abstract int getMainDisplayAssignedToUser(@UserIdInt int userId);
public abstract int getDisplayAssignedToUser(@UserIdInt int userId);
/** /**
* Returns all display ids assigned to the user including {@link * Returns all display ids assigned to the user including {@link
* #assignUserToExtraDisplay(int, int) extra displays}, or {@code null} if there is no display * #assignUserToExtraDisplay(int, int) extra displays}, or {@code null} if there is no display
* assigned to the specified user. * assigned to the specified user.
* *
* <p>Note that this method is different from {@link #getDisplayAssignedToUser(int)}, which * <p>Note that this method is different from {@link #getMainDisplayAssignedToUser(int)}, which
* returns a main display only. * returns a main display only.
*/ */
public abstract @Nullable int[] getDisplaysAssignedToUser(@UserIdInt int userId); public abstract @Nullable int[] getDisplaysAssignedToUser(@UserIdInt int userId);

View File

@@ -1996,10 +1996,10 @@ public class UserManagerService extends IUserManager.Stub {
} }
@Override @Override
public int getDisplayIdAssignedToUser() { public int getMainDisplayIdAssignedToUser() {
// Not checking for any permission as it returns info about calling user // Not checking for any permission as it returns info about calling user
int userId = UserHandle.getUserId(Binder.getCallingUid()); int userId = UserHandle.getUserId(Binder.getCallingUid());
int displayId = mUserVisibilityMediator.getDisplayAssignedToUser(userId); int displayId = mUserVisibilityMediator.getMainDisplayAssignedToUser(userId);
return displayId; return displayId;
} }
@@ -7189,8 +7189,8 @@ public class UserManagerService extends IUserManager.Stub {
} }
@Override @Override
public int getDisplayAssignedToUser(@UserIdInt int userId) { public int getMainDisplayAssignedToUser(@UserIdInt int userId) {
return mUserVisibilityMediator.getDisplayAssignedToUser(userId); return mUserVisibilityMediator.getMainDisplayAssignedToUser(userId);
} }
@Override @Override

View File

@@ -774,9 +774,9 @@ public final class UserVisibilityMediator implements Dumpable {
} }
/** /**
* See {@link UserManagerInternal#getDisplayAssignedToUser(int)}. * See {@link UserManagerInternal#getMainDisplayAssignedToUser(int)}.
*/ */
public int getDisplayAssignedToUser(@UserIdInt int userId) { public int getMainDisplayAssignedToUser(@UserIdInt int userId) {
if (isCurrentUserOrRunningProfileOfCurrentUser(userId)) { if (isCurrentUserOrRunningProfileOfCurrentUser(userId)) {
if (mVisibleBackgroundUserOnDefaultDisplayEnabled) { if (mVisibleBackgroundUserOnDefaultDisplayEnabled) {
// When device supports visible bg users on default display, the default display is // When device supports visible bg users on default display, the default display is
@@ -787,8 +787,8 @@ public final class UserVisibilityMediator implements Dumpable {
} }
if (userStartedOnDefaultDisplay != USER_NULL) { if (userStartedOnDefaultDisplay != USER_NULL) {
if (DBG) { if (DBG) {
Slogf.d(TAG, "getDisplayAssignedToUser(%d): returning INVALID_DISPLAY for " Slogf.d(TAG, "getMainDisplayAssignedToUser(%d): returning INVALID_DISPLAY "
+ "current user user %d was started on DEFAULT_DISPLAY", + "for current user user %d was started on DEFAULT_DISPLAY",
userId, userStartedOnDefaultDisplay); userId, userStartedOnDefaultDisplay);
} }
return INVALID_DISPLAY; return INVALID_DISPLAY;
@@ -809,7 +809,7 @@ public final class UserVisibilityMediator implements Dumpable {
/** See {@link UserManagerInternal#getDisplaysAssignedToUser(int)}. */ /** See {@link UserManagerInternal#getDisplaysAssignedToUser(int)}. */
@Nullable @Nullable
public int[] getDisplaysAssignedToUser(@UserIdInt int userId) { public int[] getDisplaysAssignedToUser(@UserIdInt int userId) {
int mainDisplayId = getDisplayAssignedToUser(userId); int mainDisplayId = getMainDisplayAssignedToUser(userId);
if (mainDisplayId == INVALID_DISPLAY) { if (mainDisplayId == INVALID_DISPLAY) {
// The user will not have any extra displays if they have no main display. // The user will not have any extra displays if they have no main display.
// Return null if no display is assigned to the user. // Return null if no display is assigned to the user.

View File

@@ -674,13 +674,13 @@ abstract class UserVisibilityMediatorTestCase extends ExpectableTestCase {
} }
protected void expectDisplayAssignedToUser(@UserIdInt int userId, int displayId) { protected void expectDisplayAssignedToUser(@UserIdInt int userId, int displayId) {
expectWithMessage("getDisplayAssignedToUser(%s)", userId) expectWithMessage("getMainDisplayAssignedToUser(%s)", userId)
.that(mMediator.getDisplayAssignedToUser(userId)).isEqualTo(displayId); .that(mMediator.getMainDisplayAssignedToUser(userId)).isEqualTo(displayId);
} }
protected void expectNoDisplayAssignedToUser(@UserIdInt int userId) { protected void expectNoDisplayAssignedToUser(@UserIdInt int userId) {
expectWithMessage("getDisplayAssignedToUser(%s)", userId) expectWithMessage("getMainDisplayAssignedToUser(%s)", userId)
.that(mMediator.getDisplayAssignedToUser(userId)).isEqualTo(INVALID_DISPLAY); .that(mMediator.getMainDisplayAssignedToUser(userId)).isEqualTo(INVALID_DISPLAY);
} }
protected void expectDisplaysAssignedToUserContainsDisplayId( protected void expectDisplaysAssignedToUserContainsDisplayId(