From 92adda2b616287146549d921dfe4c1199c0a4247 Mon Sep 17 00:00:00 2001 From: Seigo Nonaka Date: Tue, 2 Jun 2015 16:27:12 +0900 Subject: [PATCH] Use final in favor of initialization safety. Making a member field final would be beneficial not only for the readability but also for the initialization safety. Leaving SpellCheckerSession#mSpellCheckerSessionListener non-final does not make sense not only because we never change that member field once SpellCheckerSession object is created and but also because SpellCheckerSession instance is designed to be accessed from multiple threads at the same time, no matter if it has something to do with Bug 18945456 or not. Change-Id: I1a7ebb54a5d0beddee8799fc5b0800c6e1059099 --- core/java/android/view/textservice/SpellCheckerSession.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/java/android/view/textservice/SpellCheckerSession.java b/core/java/android/view/textservice/SpellCheckerSession.java index 84f395a02dea7..195a335c614ee 100644 --- a/core/java/android/view/textservice/SpellCheckerSession.java +++ b/core/java/android/view/textservice/SpellCheckerSession.java @@ -98,11 +98,11 @@ public class SpellCheckerSession { private final InternalListener mInternalListener; private final ITextServicesManager mTextServicesManager; private final SpellCheckerInfo mSpellCheckerInfo; + private final SpellCheckerSessionListener mSpellCheckerSessionListener; private final SpellCheckerSessionListenerImpl mSpellCheckerSessionListenerImpl; private final SpellCheckerSubtype mSubtype; private boolean mIsUsed; - private SpellCheckerSessionListener mSpellCheckerSessionListener; /** Handler that will execute the main tasks */ private final Handler mHandler = new Handler() {