diff --git a/core/java/android/net/BaseNetworkStateTracker.java b/core/java/android/net/BaseNetworkStateTracker.java index 58d00487802c1..e4e5b1e35d6c8 100644 --- a/core/java/android/net/BaseNetworkStateTracker.java +++ b/core/java/android/net/BaseNetworkStateTracker.java @@ -169,16 +169,6 @@ public abstract class BaseNetworkStateTracker implements NetworkStateTracker { // Base tracker doesn't handle dependencies } - @Override - public void addStackedLink(LinkProperties link) { - mLinkProperties.addStackedLink(link); - } - - @Override - public void removeStackedLink(LinkProperties link) { - mLinkProperties.removeStackedLink(link); - } - @Override public void supplyMessenger(Messenger messenger) { // not supported on this network diff --git a/core/java/android/net/LinkProperties.java b/core/java/android/net/LinkProperties.java index 662c57627f59c..ef731b638e88f 100644 --- a/core/java/android/net/LinkProperties.java +++ b/core/java/android/net/LinkProperties.java @@ -493,16 +493,16 @@ public final class LinkProperties implements Parcelable { /** * Removes a stacked link. * - * If there a stacked link with the same interfacename as link, it is + * If there is a stacked link with the given interface name, it is * removed. Otherwise, nothing changes. * - * @param link The link to remove. + * @param iface The interface name of the link to remove. * @return true if the link was removed, false otherwise. * @hide */ - public boolean removeStackedLink(LinkProperties link) { - if (link != null && link.getInterfaceName() != null) { - LinkProperties removed = mStackedLinks.remove(link.getInterfaceName()); + public boolean removeStackedLink(String iface) { + if (iface != null) { + LinkProperties removed = mStackedLinks.remove(iface); return removed != null; } return false; diff --git a/core/java/android/net/MobileDataStateTracker.java b/core/java/android/net/MobileDataStateTracker.java index d8012fee5beb3..40b7e066ddeea 100644 --- a/core/java/android/net/MobileDataStateTracker.java +++ b/core/java/android/net/MobileDataStateTracker.java @@ -660,16 +660,6 @@ public class MobileDataStateTracker extends BaseNetworkStateTracker { return retVal; } - @Override - public void addStackedLink(LinkProperties link) { - mLinkProperties.addStackedLink(link); - } - - @Override - public void removeStackedLink(LinkProperties link) { - mLinkProperties.removeStackedLink(link); - } - @Override public String toString() { final CharArrayWriter writer = new CharArrayWriter(); diff --git a/core/java/android/net/NetworkStateTracker.java b/core/java/android/net/NetworkStateTracker.java index 35500cc1cdb6a..c80782c4fd602 100644 --- a/core/java/android/net/NetworkStateTracker.java +++ b/core/java/android/net/NetworkStateTracker.java @@ -216,16 +216,6 @@ public interface NetworkStateTracker { */ public void setDependencyMet(boolean met); - /** - * Informs the state tracker that another interface is stacked on top of it. - **/ - public void addStackedLink(LinkProperties link); - - /** - * Informs the state tracker that a stacked interface has been removed. - **/ - public void removeStackedLink(LinkProperties link); - /* * Called once to setup async channel between this and * the underlying network specific code. diff --git a/core/tests/coretests/src/android/net/LinkPropertiesTest.java b/core/tests/coretests/src/android/net/LinkPropertiesTest.java index 4015b3d65bc7d..5b1a59ce9b5d2 100644 --- a/core/tests/coretests/src/android/net/LinkPropertiesTest.java +++ b/core/tests/coretests/src/android/net/LinkPropertiesTest.java @@ -338,14 +338,14 @@ public class LinkPropertiesTest extends TestCase { assertFalse("newname".equals(link.getInterfaceName())); } - assertTrue(rmnet0.removeStackedLink(clat4)); + assertTrue(rmnet0.removeStackedLink("clat4")); assertEquals(0, rmnet0.getStackedLinks().size()); assertEquals(1, rmnet0.getAddresses().size()); assertEquals(1, rmnet0.getLinkAddresses().size()); assertEquals(1, rmnet0.getAllAddresses().size()); assertEquals(1, rmnet0.getAllLinkAddresses().size()); - assertFalse(rmnet0.removeStackedLink(clat4)); + assertFalse(rmnet0.removeStackedLink("clat4")); } private LinkAddress getFirstLinkAddress(LinkProperties lp) { @@ -370,7 +370,7 @@ public class LinkPropertiesTest extends TestCase { assertTrue(stacked.hasGlobalIPv6Address()); assertFalse(lp.hasIPv4Address()); assertFalse(lp.hasGlobalIPv6Address()); - lp.removeStackedLink(stacked); + lp.removeStackedLink("stacked"); assertFalse(lp.hasIPv4Address()); assertFalse(lp.hasGlobalIPv6Address()); diff --git a/services/core/java/com/android/server/connectivity/Nat464Xlat.java b/services/core/java/com/android/server/connectivity/Nat464Xlat.java index c382be07f6f1b..3b0d8c1d2df98 100644 --- a/services/core/java/com/android/server/connectivity/Nat464Xlat.java +++ b/services/core/java/com/android/server/connectivity/Nat464Xlat.java @@ -217,7 +217,7 @@ public class Nat464Xlat extends BaseNetworkObserver { NetworkUtils.resetConnections( CLAT_INTERFACE_NAME, NetworkUtils.RESET_IPV4_ADDRESSES); - mBaseLP.removeStackedLink(mLP); + mBaseLP.removeStackedLink(CLAT_INTERFACE_NAME); updateConnectivityService(); } Slog.i(TAG, "interface " + CLAT_INTERFACE_NAME +