From 10d69ea7d38d712bb064fabaa257875c0a02fce9 Mon Sep 17 00:00:00 2001 From: Mihai Popa Date: Fri, 26 Jan 2018 15:09:48 +0000 Subject: [PATCH] [Magnifier - 18] Make #update() public The CL adds the Magnifier#update() method in the public API. The method is used to refresh the content of the magnifier, whenever this is desired (usually when there is a chance that the magnifier content became stale). The initial plan was that this method would not be included in the public API. This was relying on a feature request we made to the graphics team, asking for support to have a callback called whenever the surface the magnifier is attached to changes. This way, we could refresh the magnifier content whenever the surface changes, without requiring the user to call #update(). Once the feature request is implemented (probably in Q according to the last discussion), we will be able to deprecate #update(). Bug: 63531115 Test: atest CtsWidgetTestCases:android.widget.cts.MagnifierTest Change-Id: I62c5794c3227e6a5d36d351c10d6bcf18e1d931a --- api/current.txt | 1 + core/java/android/widget/Magnifier.java | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/api/current.txt b/api/current.txt index 2794a76617440..8305ee9793fc1 100644 --- a/api/current.txt +++ b/api/current.txt @@ -52292,6 +52292,7 @@ package android.widget { ctor public Magnifier(android.view.View); method public void dismiss(); method public void show(float, float); + method public void update(); } public class MediaController extends android.widget.FrameLayout { diff --git a/core/java/android/widget/Magnifier.java b/core/java/android/widget/Magnifier.java index e42217f710c41..7a4c800ba15ed 100644 --- a/core/java/android/widget/Magnifier.java +++ b/core/java/android/widget/Magnifier.java @@ -182,8 +182,6 @@ public final class Magnifier { /** * Forces the magnifier to update its content. It uses the previous coordinates passed to * {@link #show(float, float)}. This only happens if the magnifier is currently showing. - * - * @hide */ public void update() { if (mWindow.isShowing()) {