From 108be5bcfad8fdd6474cc88b15f9a21419667189 Mon Sep 17 00:00:00 2001 From: Adlai Holler Date: Tue, 20 Apr 2021 14:37:29 +0000 Subject: [PATCH] Always use Skia reduceOpsTaskSplitting This feature was previously limited to high-end devices, but now that there is a fallback when VRAM is limited, it will be enabled globally. After the feature is rolled out to all major Skia clients, it will be the only way things work. Bug: 183612348 Change-Id: Ia99ec154b498ab9315ec5f5285241fde8136c4ab --- libs/hwui/Properties.h | 2 +- libs/hwui/renderthread/RenderThread.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libs/hwui/Properties.h b/libs/hwui/Properties.h index 1cb87be98051f..01c157123c507 100644 --- a/libs/hwui/Properties.h +++ b/libs/hwui/Properties.h @@ -178,7 +178,7 @@ enum DebugLevel { /** * Turns on the Skia GPU option "reduceOpsTaskSplitting" which improves GPU - * efficiency but may increase VRAM consumption. Default is "false". + * efficiency but may increase VRAM consumption. Default is "true". */ #define PROPERTY_REDUCE_OPS_TASK_SPLITTING "renderthread.skia.reduceopstasksplitting" diff --git a/libs/hwui/renderthread/RenderThread.cpp b/libs/hwui/renderthread/RenderThread.cpp index 04aa1cb91492d..3421e01b15859 100644 --- a/libs/hwui/renderthread/RenderThread.cpp +++ b/libs/hwui/renderthread/RenderThread.cpp @@ -275,7 +275,7 @@ void RenderThread::requireVkContext() { void RenderThread::initGrContextOptions(GrContextOptions& options) { options.fPreferExternalImagesOverES3 = true; options.fDisableDistanceFieldPaths = true; - if (android::base::GetBoolProperty(PROPERTY_REDUCE_OPS_TASK_SPLITTING, false)) { + if (android::base::GetBoolProperty(PROPERTY_REDUCE_OPS_TASK_SPLITTING, true)) { options.fReduceOpsTaskSplitting = GrContextOptions::Enable::kYes; } else { options.fReduceOpsTaskSplitting = GrContextOptions::Enable::kNo;