Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added read phone state permission for getNetworkCountryIso

Browse Source 
The slot based version of getNetworkCountryIso is a system API.
So it needs to be gaurded by permission.

Bug: 141646066
Test: Telephony sanity tests
Change-Id: I810ff0b77b93870ae3f62769977c7094789d0a5a
This commit is contained in:
Jack Yu
2019-09-26 11:44:52 -07:00
parent 6c98b3a672
commit 105f65068c
4 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
api/system-current.txt
View File

@@ -8236,7 +8236,7 @@ package android.telephony {
method @Nullable @RequiresPermission(android.Manifest.permission.READ_PRIVILEGED_PHONE_STATE) public String getIsimIst(); method @Nullable @RequiresPermission(android.Manifest.permission.READ_PRIVILEGED_PHONE_STATE) public String getIsimIst();
method @NonNull @RequiresPermission(android.Manifest.permission.READ_PRIVILEGED_PHONE_STATE) public java.util.Map<java.lang.Integer,java.lang.Integer> getLogicalToPhysicalSlotMapping(); method @NonNull @RequiresPermission(android.Manifest.permission.READ_PRIVILEGED_PHONE_STATE) public java.util.Map<java.lang.Integer,java.lang.Integer> getLogicalToPhysicalSlotMapping();
method public static long getMaxNumberVerificationTimeoutMillis(); method public static long getMaxNumberVerificationTimeoutMillis();
method @NonNull public String getNetworkCountryIso(int); method @NonNull @RequiresPermission(android.Manifest.permission.READ_PRIVILEGED_PHONE_STATE) public String getNetworkCountryIso(int);
method @RequiresPermission(android.Manifest.permission.READ_PRIVILEGED_PHONE_STATE) public long getPreferredNetworkTypeBitmask(); method @RequiresPermission(android.Manifest.permission.READ_PRIVILEGED_PHONE_STATE) public long getPreferredNetworkTypeBitmask();
method @RequiresPermission(anyOf={android.Manifest.permission.READ_PRIVILEGED_PHONE_STATE, android.Manifest.permission.READ_PHONE_STATE}) public int getRadioPowerState(); method @RequiresPermission(anyOf={android.Manifest.permission.READ_PRIVILEGED_PHONE_STATE, android.Manifest.permission.READ_PHONE_STATE}) public int getRadioPowerState();
method public int getSimApplicationState(); method public int getSimApplicationState();

2
api/test-current.txt
View File

@@ -2914,7 +2914,7 @@ package android.telephony {
method public int checkCarrierPrivilegesForPackage(String); method public int checkCarrierPrivilegesForPackage(String);
method public int getCarrierIdListVersion(); method public int getCarrierIdListVersion();
method @RequiresPermission(android.Manifest.permission.READ_PHONE_STATE) public String getLine1AlphaTag(); method @RequiresPermission(android.Manifest.permission.READ_PHONE_STATE) public String getLine1AlphaTag();
method @NonNull public String getNetworkCountryIso(int); method @NonNull @RequiresPermission("android.permission.READ_PRIVILEGED_PHONE_STATE") public String getNetworkCountryIso(int);
method public android.util.Pair<java.lang.Integer,java.lang.Integer> getRadioHalVersion(); method public android.util.Pair<java.lang.Integer,java.lang.Integer> getRadioHalVersion();
method @RequiresPermission(android.Manifest.permission.MODIFY_PHONE_STATE) public void refreshUiccProfile(); method @RequiresPermission(android.Manifest.permission.MODIFY_PHONE_STATE) public void refreshUiccProfile();
method @Deprecated public void setCarrierTestOverride(String, String, String, String, String, String, String); method @Deprecated public void setCarrierTestOverride(String, String, String, String, String, String, String);

12
telephony/java/android/telephony/TelephonyManager.java
View File

@@ -2449,7 +2449,14 @@ public class TelephonyManager {
* @return the lowercase 2 character ISO-3166 country code, or empty string if not available. * @return the lowercase 2 character ISO-3166 country code, or empty string if not available.
*/ */
public String getNetworkCountryIso() { public String getNetworkCountryIso() {
return getNetworkCountryIso(getPhoneId()); try {
ITelephony telephony = getITelephony();
if (telephony == null) return "";
return telephony.getNetworkCountryIsoForPhone(getPhoneId(),
null /* no permission check */);
} catch (RemoteException ex) {
return "";
}
} }
/** /**
@@ -2475,11 +2482,12 @@ public class TelephonyManager {
@SystemApi @SystemApi
@TestApi @TestApi
@NonNull @NonNull
@RequiresPermission(android.Manifest.permission.READ_PRIVILEGED_PHONE_STATE)
public String getNetworkCountryIso(int slotIndex) { public String getNetworkCountryIso(int slotIndex) {
try { try {
ITelephony telephony = getITelephony(); ITelephony telephony = getITelephony();
if (telephony == null) return ""; if (telephony == null) return "";
return telephony.getNetworkCountryIsoForPhone(slotIndex); return telephony.getNetworkCountryIsoForPhone(slotIndex, getOpPackageName());
} catch (RemoteException ex) { } catch (RemoteException ex) {
return ""; return "";
} }

2
telephony/java/com/android/internal/telephony/ITelephony.aidl
View File

@@ -302,7 +302,7 @@ interface ITelephony {
* operator's MCC (Mobile Country Code). * operator's MCC (Mobile Country Code).
* @see android.telephony.TelephonyManager#getNetworkCountryIso * @see android.telephony.TelephonyManager#getNetworkCountryIso
*/ */
String getNetworkCountryIsoForPhone(int phoneId); String getNetworkCountryIsoForPhone(int phoneId, String callingPkg);
/** /**
* Returns the neighboring cell information of the device. * Returns the neighboring cell information of the device.