Merge "Avoid unnecessary dup" into sc-v2-dev

This commit is contained in:
Ytai Ben-tsvi
2021-10-18 20:24:41 +00:00
committed by Android (Google) Code Review

View File

@@ -429,15 +429,7 @@ class ConversionUtil {
private static @NonNull private static @NonNull
HidlMemory parcelFileDescriptorToHidlMemory(@Nullable ParcelFileDescriptor data, int dataSize) { HidlMemory parcelFileDescriptorToHidlMemory(@Nullable ParcelFileDescriptor data, int dataSize) {
if (dataSize > 0) { if (dataSize > 0) {
// Extract a dup of the underlying FileDescriptor out of data. return HidlMemoryUtil.fileDescriptorToHidlMemory(data.getFileDescriptor(), dataSize);
FileDescriptor fd = new FileDescriptor();
try {
ParcelFileDescriptor dup = data.dup();
fd.setInt$(dup.detachFd());
return HidlMemoryUtil.fileDescriptorToHidlMemory(fd, dataSize);
} catch (IOException e) {
throw new RuntimeException(e);
}
} else { } else {
return HidlMemoryUtil.fileDescriptorToHidlMemory(null, 0); return HidlMemoryUtil.fileDescriptorToHidlMemory(null, 0);
} }