Merge "Avoid potential NPE if the restore-below task is not collected" into tm-qpr-dev

This commit is contained in:
Riddle Hsu
2022-06-14 12:25:51 +00:00
committed by Android (Google) Code Review
2 changed files with 13 additions and 8 deletions

View File

@@ -1660,14 +1660,17 @@ class ActivityStarter {
transitionController.collect(r); transitionController.collect(r);
try { try {
mService.deferWindowLayout(); mService.deferWindowLayout();
Trace.traceBegin(Trace.TRACE_TAG_WINDOW_MANAGER, "startActivityInner"); try {
result = startActivityInner(r, sourceRecord, voiceSession, voiceInteractor, Trace.traceBegin(Trace.TRACE_TAG_WINDOW_MANAGER, "startActivityInner");
startFlags, doResume, options, inTask, inTaskFragment, restrictedBgActivity, result = startActivityInner(r, sourceRecord, voiceSession, voiceInteractor,
intentGrants); startFlags, doResume, options, inTask, inTaskFragment, restrictedBgActivity,
intentGrants);
} finally {
Trace.traceEnd(Trace.TRACE_TAG_WINDOW_MANAGER);
startedActivityRootTask = handleStartResult(r, options, result, newTransition,
remoteTransition);
}
} finally { } finally {
Trace.traceEnd(Trace.TRACE_TAG_WINDOW_MANAGER);
startedActivityRootTask = handleStartResult(r, options, result, newTransition,
remoteTransition);
mService.continueWindowLayout(); mService.continueWindowLayout();
} }
postStartActivityProcessing(r, result, startedActivityRootTask); postStartActivityProcessing(r, result, startedActivityRootTask);

View File

@@ -229,7 +229,9 @@ class Transition extends Binder implements BLASTSyncEngine.TransactionReadyListe
if (restoreBelow != null) { if (restoreBelow != null) {
final ChangeInfo info = mChanges.get(restoreBelow); final ChangeInfo info = mChanges.get(restoreBelow);
info.mFlags |= ChangeInfo.FLAG_ABOVE_TRANSIENT_LAUNCH; if (info != null) {
info.mFlags |= ChangeInfo.FLAG_ABOVE_TRANSIENT_LAUNCH;
}
} }
ProtoLog.v(ProtoLogGroup.WM_DEBUG_WINDOW_TRANSITIONS, "Transition %d: Set %s as " ProtoLog.v(ProtoLogGroup.WM_DEBUG_WINDOW_TRANSITIONS, "Transition %d: Set %s as "
+ "transient-launch", mSyncId, activity); + "transient-launch", mSyncId, activity);