From f6d72ca6540d914381488217be2771b21d483e0b Mon Sep 17 00:00:00 2001 From: Michal Brzezinski Date: Wed, 16 Jun 2021 14:37:35 +0100 Subject: [PATCH] Hiding split shade media container when not needed Media container that is used only on the lockscreen in split shade mode is initially visible when user didn't interact with media. It doesn't contain media player itself, but has padding that interferes with other layout elements. It's properly hidden only after user sees media widget. This change makes sure that when media should not be visible, every container is marked as GONE. Fixes: 191010901 Test: restart device and see if empty container is present. HSV after fix: https://hsv.googleplex.com/5408886683074560?node=34 Change-Id: Ib184ba747531da5d288df6381189c5237f1aef6c --- .../com/android/systemui/media/KeyguardMediaController.kt | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/media/KeyguardMediaController.kt b/packages/SystemUI/src/com/android/systemui/media/KeyguardMediaController.kt index 77d789292e5e0..2bf102f724f4b 100644 --- a/packages/SystemUI/src/com/android/systemui/media/KeyguardMediaController.kt +++ b/packages/SystemUI/src/com/android/systemui/media/KeyguardMediaController.kt @@ -186,11 +186,9 @@ class KeyguardMediaController @Inject constructor( } private fun hideMediaPlayer() { - if (useSplitShade) { - setVisibility(splitShadeContainer, View.GONE) - } else { - setVisibility(singlePaneContainer, View.GONE) - } + // always hide splitShadeContainer as it's initially visible and may influence layout + setVisibility(splitShadeContainer, View.GONE) + setVisibility(singlePaneContainer, View.GONE) } private fun setVisibility(view: ViewGroup?, newVisibility: Int) {