Merge "Marshal dream overlay connection logic with Handler." into tm-qpr-dev

This commit is contained in:
Bryce Lee
2022-04-27 17:12:18 +00:00
committed by Android (Google) Code Review

View File

@@ -251,6 +251,8 @@ public class DreamService extends Service implements Window.Callback {
// A Queue of pending requests to execute on the overlay. // A Queue of pending requests to execute on the overlay.
private final ArrayDeque<Consumer<IDreamOverlay>> mRequests; private final ArrayDeque<Consumer<IDreamOverlay>> mRequests;
private Handler mHandler = new Handler(Looper.getMainLooper());
private boolean mBound; private boolean mBound;
OverlayConnection() { OverlayConnection() {
@@ -259,6 +261,7 @@ public class DreamService extends Service implements Window.Callback {
public void bind(Context context, @Nullable ComponentName overlayService, public void bind(Context context, @Nullable ComponentName overlayService,
ComponentName dreamService) { ComponentName dreamService) {
mHandler.post(() -> {
if (overlayService == null) { if (overlayService == null) {
return; return;
} }
@@ -273,20 +276,25 @@ public class DreamService extends Service implements Window.Callback {
context.bindService(overlayIntent, context.bindService(overlayIntent,
this, Context.BIND_AUTO_CREATE | Context.BIND_FOREGROUND_SERVICE); this, Context.BIND_AUTO_CREATE | Context.BIND_FOREGROUND_SERVICE);
mBound = true; mBound = true;
});
} }
public void unbind(Context context) { public void unbind(Context context) {
mHandler.post(() -> {
if (!mBound) { if (!mBound) {
return; return;
} }
context.unbindService(this); context.unbindService(this);
mBound = false; mBound = false;
});
} }
public void request(Consumer<IDreamOverlay> request) { public void request(Consumer<IDreamOverlay> request) {
mHandler.post(() -> {
mRequests.push(request); mRequests.push(request);
evaluate(); evaluate();
});
} }
private void evaluate() { private void evaluate() {
@@ -304,15 +312,19 @@ public class DreamService extends Service implements Window.Callback {
@Override @Override
public void onServiceConnected(ComponentName name, IBinder service) { public void onServiceConnected(ComponentName name, IBinder service) {
mHandler.post(() -> {
// Store Overlay and execute pending requests. // Store Overlay and execute pending requests.
mOverlay = IDreamOverlay.Stub.asInterface(service); mOverlay = IDreamOverlay.Stub.asInterface(service);
evaluate(); evaluate();
});
} }
@Override @Override
public void onServiceDisconnected(ComponentName name) { public void onServiceDisconnected(ComponentName name) {
mHandler.post(() -> {
// Clear Overlay binder to prevent further request processing. // Clear Overlay binder to prevent further request processing.
mOverlay = null; mOverlay = null;
});
} }
} }