Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix crash opening avatar picker in non-en-US locale." into udc-dev

Browse Source
This commit is contained in:
Oli Lan
2023-06-20 16:39:04 +00:00
committed by Android (Google) Code Review
parent 833a6c895a f756b2623f
commit 0f3d66a93a
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/SettingsLib/res/values/arrays.xml
View File

@@ -643,8 +643,10 @@
array must also be populated with a content description for each image. --> array must also be populated with a content description for each image. -->
<array name="avatar_images"/> <array name="avatar_images"/>
<!-- Content descriptions for each of the images in the avatar_images array. --> <!-- Content descriptions for each of the images in the avatar_images array. When overlaid
<string-array name="avatar_image_descriptions"/> these values should be translated, but this empty array must not be translated or it may
replace the real descriptions with an empty array. -->
<string-array name="avatar_image_descriptions" translatable="false"/>
<!-- NOTE: if you change this, you must also add the corresponding scale key and lookup table to <!-- NOTE: if you change this, you must also add the corresponding scale key and lookup table to
frameworks/base/core/java/android/content/res/FontScaleConverterFactory.java --> frameworks/base/core/java/android/content/res/FontScaleConverterFactory.java -->

2
packages/SettingsLib/src/com/android/settingslib/users/AvatarPickerActivity.java
View File

@@ -243,7 +243,7 @@ public class AvatarPickerActivity extends Activity {
int index = indexFromPosition(position); int index = indexFromPosition(position);
viewHolder.setSelected(position == mSelectedPosition); viewHolder.setSelected(position == mSelectedPosition);
viewHolder.setDrawable(mImageDrawables.get(index)); viewHolder.setDrawable(mImageDrawables.get(index));
if (mImageDescriptions != null) { if (mImageDescriptions != null && index < mImageDescriptions.size()) {
viewHolder.setContentDescription(mImageDescriptions.get(index)); viewHolder.setContentDescription(mImageDescriptions.get(index));
} else { } else {
viewHolder.setContentDescription(getString( viewHolder.setContentDescription(getString(