From 0f2513cbb7dc194b670d7b558f9144dfb0ac4fc7 Mon Sep 17 00:00:00 2001 From: Caitlin Cassidy Date: Tue, 20 Jul 2021 17:17:52 +0000 Subject: [PATCH] [Dagger] Add BatteryMeterViewController. Future CLs will move Dependency.get calls from BatteryMeterView to this controller. BatteryMeterView is used in QuickStatusBarHeader, KeyguardStatusBarView, PhoneStatusBarView, and SplitShadeHeaderController, so BatteryMeterViewController is added to the controllers for those views. Bug: 138786270 Test: atest and manual Change-Id: I4d23a32d4ecda4f4327552b3703e9893ad544bdb --- .../res/layout/quick_qs_status_icons.xml | 2 +- .../res/layout/split_shade_header.xml | 2 +- packages/SystemUI/res/layout/system_icons.xml | 2 +- .../dagger/KeyguardStatusBarViewModule.java | 8 +++++ .../{ => battery}/BatteryMeterView.java | 7 ++-- .../battery/BatteryMeterViewController.java | 36 +++++++++++++++++++ .../systemui/qs/QuickStatusBarHeader.java | 2 +- .../qs/QuickStatusBarHeaderController.java | 11 +++++- .../systemui/qs/dagger/QSFragmentModule.java | 7 ++++ .../phone/KeyguardStatusBarView.java | 2 +- .../KeyguardStatusBarViewController.java | 7 +++- .../phone/SplitShadeHeaderController.kt | 7 ++-- .../systemui/statusbar/phone/StatusBar.java | 9 ++++- .../phone/dagger/StatusBarViewModule.java | 8 +++++ .../qs/QuickStatusBarHeaderControllerTest.kt | 6 +++- .../KeyguardStatusBarViewControllerTest.java | 6 +++- 16 files changed, 108 insertions(+), 14 deletions(-) rename packages/SystemUI/src/com/android/systemui/{ => battery}/BatteryMeterView.java (98%) create mode 100644 packages/SystemUI/src/com/android/systemui/battery/BatteryMeterViewController.java diff --git a/packages/SystemUI/res/layout/quick_qs_status_icons.xml b/packages/SystemUI/res/layout/quick_qs_status_icons.xml index 1086c2b5a54fb..1460cdff7e130 100644 --- a/packages/SystemUI/res/layout/quick_qs_status_icons.xml +++ b/packages/SystemUI/res/layout/quick_qs_status_icons.xml @@ -97,7 +97,7 @@ android:layout_height="match_parent" android:paddingEnd="@dimen/signal_cluster_battery_padding" /> - - - { + + @Inject + public BatteryMeterViewController(BatteryMeterView view) { + super(view); + } + + @Override + protected void onViewAttached() { + } + + @Override + protected void onViewDetached() { + } +} diff --git a/packages/SystemUI/src/com/android/systemui/qs/QuickStatusBarHeader.java b/packages/SystemUI/src/com/android/systemui/qs/QuickStatusBarHeader.java index 377c6677493f5..8cb9d46d273a8 100644 --- a/packages/SystemUI/src/com/android/systemui/qs/QuickStatusBarHeader.java +++ b/packages/SystemUI/src/com/android/systemui/qs/QuickStatusBarHeader.java @@ -35,8 +35,8 @@ import android.widget.Space; import androidx.annotation.NonNull; import com.android.settingslib.Utils; -import com.android.systemui.BatteryMeterView; import com.android.systemui.R; +import com.android.systemui.battery.BatteryMeterView; import com.android.systemui.qs.QSDetail.Callback; import com.android.systemui.statusbar.phone.StatusBarIconController.TintedIconManager; import com.android.systemui.statusbar.phone.StatusBarWindowView; diff --git a/packages/SystemUI/src/com/android/systemui/qs/QuickStatusBarHeaderController.java b/packages/SystemUI/src/com/android/systemui/qs/QuickStatusBarHeaderController.java index 1343839807ef7..a44573ff87050 100644 --- a/packages/SystemUI/src/com/android/systemui/qs/QuickStatusBarHeaderController.java +++ b/packages/SystemUI/src/com/android/systemui/qs/QuickStatusBarHeaderController.java @@ -25,6 +25,7 @@ import androidx.annotation.NonNull; import com.android.internal.colorextraction.ColorExtractor; import com.android.internal.logging.UiEventLogger; import com.android.systemui.R; +import com.android.systemui.battery.BatteryMeterViewController; import com.android.systemui.colorextraction.SysuiColorExtractor; import com.android.systemui.demomode.DemoMode; import com.android.systemui.demomode.DemoModeController; @@ -71,6 +72,7 @@ class QuickStatusBarHeaderController extends ViewController