Merge "Fixed NPE in RankingHelper.writeXml. Make sure that mRecords is operated with the object lock."

am: 51e5edcb9b Change-Id: I4f57eb27caffbf6462dcad23660f05efce21e74e
2019-03-29 07:18:23 -07:00
parent 3eb37cda43 51e5edcb9b
commit 0eda9fd9dd
1 changed files with 8 additions and 5 deletions
--- a/services/core/java/com/android/server/notification/RankingHelper.java
+++ b/services/core/java/com/android/server/notification/RankingHelper.java
@@ -1401,11 +1401,14 @@ public class RankingHelper implements RankingConfig {
                }
                // Package upgrade
                try {
-                    Record fullRecord = getRecord(pkg,
-                            mPm.getPackageUidAsUser(pkg, changeUserId));
-                    if (fullRecord != null) {
-                        createDefaultChannelIfNeeded(fullRecord);
-                        deleteDefaultChannelIfNeeded(fullRecord);
+                    synchronized (mRecords) {
+                        final String key = recordKey(pkg,
+                                mPm.getPackageUidAsUser(pkg, changeUserId));
+                        Record fullRecord = mRecords.get(key);
+                        if (fullRecord != null) {
+                            createDefaultChannelIfNeeded(fullRecord);
+                            deleteDefaultChannelIfNeeded(fullRecord);
+                        }
                    }
                } catch (NameNotFoundException e) {}
            }