From 8298653417d9b92a46df6949e62c7c3f86918428 Mon Sep 17 00:00:00 2001
From: Sunny Shao <sunnyshao@google.com>
Date: Fri, 9 Aug 2019 17:04:19 +0800
Subject: [PATCH] Update the Builder to add the title parameter checking

Fixes: 139163212
Test: compilation
Change-Id: Ieccaabff5d01c6d8043505661fa77b1b0a174485
---
 .../com/android/settingslib/widget/FooterPreference.java | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/packages/SettingsLib/src/com/android/settingslib/widget/FooterPreference.java b/packages/SettingsLib/src/com/android/settingslib/widget/FooterPreference.java
index e48becf18d7f1..15576182c53a0 100644
--- a/packages/SettingsLib/src/com/android/settingslib/widget/FooterPreference.java
+++ b/packages/SettingsLib/src/com/android/settingslib/widget/FooterPreference.java
@@ -99,7 +99,7 @@ public class FooterPreference extends Preference {
          * To set the key value of the {@link FooterPreference}.
          * @param key The key value.
          */
-        public Builder setKey(String key) {
+        public Builder setKey(@NonNull String key) {
             mKey = key;
             return this;
         }
@@ -128,12 +128,13 @@ public class FooterPreference extends Preference {
         public FooterPreference build() {
             final FooterPreference footerPreference = new FooterPreference(mContext);
             footerPreference.setSelectable(false);
+            if (TextUtils.isEmpty(mTitle)) {
+                throw new IllegalArgumentException("Footer title cannot be empty!");
+            }
+            footerPreference.setTitle(mTitle);
             if (!TextUtils.isEmpty(mKey)) {
                 footerPreference.setKey(mKey);
             }
-            if (!TextUtils.isEmpty(mTitle)) {
-                footerPreference.setTitle(mTitle);
-            }
             return footerPreference;
         }
     }