Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Revert accidental API change to RemoteViews." into oc-dev

Browse Source
This commit is contained in:
Daniel Sandler
2017-06-14 20:12:32 +00:00
committed by Android (Google) Code Review
parent 511c95a022 23bb5bf262
commit 0e6a5f8d7e
1 changed files with 16 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
core/java/android/widget/RemoteViews.java
View File

@@ -2342,24 +2342,26 @@ public class RemoteViews implements Parcelable, Filter {
} }
public synchronized RemoteViews clone() { public RemoteViews clone() {
Preconditions.checkState(mIsRoot, "RemoteView has been attached to another RemoteView. " synchronized (this) {
+ "May only clone the root of a RemoteView hierarchy."); Preconditions.checkState(mIsRoot, "RemoteView has been attached to another RemoteView. "
+ "May only clone the root of a RemoteView hierarchy.");
Parcel p = Parcel.obtain(); Parcel p = Parcel.obtain();
// Do not parcel the Bitmap cache - doing so creates an expensive copy of all bitmaps. // Do not parcel the Bitmap cache - doing so creates an expensive copy of all bitmaps.
// Instead pretend we're not owning the cache while parceling. // Instead pretend we're not owning the cache while parceling.
mIsRoot = false; mIsRoot = false;
writeToParcel(p, PARCELABLE_ELIDE_DUPLICATES); writeToParcel(p, PARCELABLE_ELIDE_DUPLICATES);
p.setDataPosition(0); p.setDataPosition(0);
mIsRoot = true; mIsRoot = true;
RemoteViews rv = new RemoteViews(p, mBitmapCache.clone(), mApplication, 0); RemoteViews rv = new RemoteViews(p, mBitmapCache.clone(), mApplication, 0);
rv.mIsRoot = true; rv.mIsRoot = true;
p.recycle(); p.recycle();
return rv; return rv;
}
} }
public String getPackage() { public String getPackage() {