From c956ac6064c9cccc99fbb7205aed0eb27997921f Mon Sep 17 00:00:00 2001 From: Daniel Norman Date: Wed, 1 Feb 2023 11:24:23 -0800 Subject: [PATCH] Minor resource cleanup for A11yMenu. - Adds `supportsRtl`, matching AAS version. - Uses string resource for app name - Fixes app icon to use adaptive icon - Adds sw600dp intro images, copied from AAS version. - Adds javadocs to adjustBrightness() mentioning SysUI slider Bug: 261252772 Test: inspect modified resources on device Change-Id: Ibb47b7bfbf88e727f2dfdaaeb9e8f9e6c5602886 --- .../accessibilitymenu/AndroidManifest.xml | 5 +- .../drawable-sw600dp-night/a11ymenu_intro.xml | 276 ++++++++++++++++++ .../res/drawable-sw600dp/a11ymenu_intro.xml | 141 +++++++++ .../res/drawable/ic_logo_a11y_menu.xml | 33 --- .../res/drawable/ic_logo_app.xml | 8 + ...u_round.xml => ic_logo_app_foreground.xml} | 0 .../AccessibilityMenuService.java | 7 + 7 files changed, 435 insertions(+), 35 deletions(-) create mode 100644 packages/SystemUI/accessibility/accessibilitymenu/res/drawable-sw600dp-night/a11ymenu_intro.xml create mode 100644 packages/SystemUI/accessibility/accessibilitymenu/res/drawable-sw600dp/a11ymenu_intro.xml delete mode 100644 packages/SystemUI/accessibility/accessibilitymenu/res/drawable/ic_logo_a11y_menu.xml create mode 100644 packages/SystemUI/accessibility/accessibilitymenu/res/drawable/ic_logo_app.xml rename packages/SystemUI/accessibility/accessibilitymenu/res/drawable/{ic_a11y_menu_round.xml => ic_logo_app_foreground.xml} (100%) diff --git a/packages/SystemUI/accessibility/accessibilitymenu/AndroidManifest.xml b/packages/SystemUI/accessibility/accessibilitymenu/AndroidManifest.xml index 0b4d7cd2247ac..77412d993dff9 100644 --- a/packages/SystemUI/accessibility/accessibilitymenu/AndroidManifest.xml +++ b/packages/SystemUI/accessibility/accessibilitymenu/AndroidManifest.xml @@ -19,11 +19,12 @@ - + diff --git a/packages/SystemUI/accessibility/accessibilitymenu/res/drawable-sw600dp-night/a11ymenu_intro.xml b/packages/SystemUI/accessibility/accessibilitymenu/res/drawable-sw600dp-night/a11ymenu_intro.xml new file mode 100644 index 0000000000000..7a4fbb207188e --- /dev/null +++ b/packages/SystemUI/accessibility/accessibilitymenu/res/drawable-sw600dp-night/a11ymenu_intro.xml @@ -0,0 +1,276 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/packages/SystemUI/accessibility/accessibilitymenu/res/drawable-sw600dp/a11ymenu_intro.xml b/packages/SystemUI/accessibility/accessibilitymenu/res/drawable-sw600dp/a11ymenu_intro.xml new file mode 100644 index 0000000000000..f0fbc48691b85 --- /dev/null +++ b/packages/SystemUI/accessibility/accessibilitymenu/res/drawable-sw600dp/a11ymenu_intro.xml @@ -0,0 +1,141 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/packages/SystemUI/accessibility/accessibilitymenu/res/drawable/ic_logo_a11y_menu.xml b/packages/SystemUI/accessibility/accessibilitymenu/res/drawable/ic_logo_a11y_menu.xml deleted file mode 100644 index 79e0e08d88992..0000000000000 --- a/packages/SystemUI/accessibility/accessibilitymenu/res/drawable/ic_logo_a11y_menu.xml +++ /dev/null @@ -1,33 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - diff --git a/packages/SystemUI/accessibility/accessibilitymenu/res/drawable/ic_logo_app.xml b/packages/SystemUI/accessibility/accessibilitymenu/res/drawable/ic_logo_app.xml new file mode 100644 index 0000000000000..31fe99e1fca17 --- /dev/null +++ b/packages/SystemUI/accessibility/accessibilitymenu/res/drawable/ic_logo_app.xml @@ -0,0 +1,8 @@ + + + + + + diff --git a/packages/SystemUI/accessibility/accessibilitymenu/res/drawable/ic_a11y_menu_round.xml b/packages/SystemUI/accessibility/accessibilitymenu/res/drawable/ic_logo_app_foreground.xml similarity index 100% rename from packages/SystemUI/accessibility/accessibilitymenu/res/drawable/ic_a11y_menu_round.xml rename to packages/SystemUI/accessibility/accessibilitymenu/res/drawable/ic_logo_app_foreground.xml diff --git a/packages/SystemUI/accessibility/accessibilitymenu/src/com/android/systemui/accessibility/accessibilitymenu/AccessibilityMenuService.java b/packages/SystemUI/accessibility/accessibilitymenu/src/com/android/systemui/accessibility/accessibilitymenu/AccessibilityMenuService.java index ecb2bf4a04e51..ca6c332579e1e 100644 --- a/packages/SystemUI/accessibility/accessibilitymenu/src/com/android/systemui/accessibility/accessibilitymenu/AccessibilityMenuService.java +++ b/packages/SystemUI/accessibility/accessibilitymenu/src/com/android/systemui/accessibility/accessibilitymenu/AccessibilityMenuService.java @@ -228,6 +228,13 @@ public class AccessibilityMenuService extends AccessibilityService mA11yMenuLayout.hideMenu(); } + /** + * Adjusts brightness using the same logic and utils class as the SystemUI brightness slider. + * + * @see BrightnessUtils + * @see com.android.systemui.settings.brightness.BrightnessController + * @param increment The increment amount in gamma-space + */ private void adjustBrightness(int increment) { BrightnessInfo info = getDisplay().getBrightnessInfo(); int gamma = BrightnessUtils.convertLinearToGammaFloat(