diff --git a/libs/androidfw/ResourceTypes.cpp b/libs/androidfw/ResourceTypes.cpp index b8d95e4acb5fe..359cface8b7f1 100644 --- a/libs/androidfw/ResourceTypes.cpp +++ b/libs/androidfw/ResourceTypes.cpp @@ -4765,7 +4765,6 @@ nope: && (targetTypeLen = attrPrivate.size()) ); } - break; } return 0; } diff --git a/libs/androidfw/tests/data/basic/R.h b/libs/androidfw/tests/data/basic/R.h index 8e9741efd2a30..94a2a14ced878 100644 --- a/libs/androidfw/tests/data/basic/R.h +++ b/libs/androidfw/tests/data/basic/R.h @@ -44,8 +44,8 @@ struct R { density = 0x7f030002, // From feature - test3 = 0x7f080000, - test4 = 0x7f080001, + test3 = 0x80020000, + test4 = 0x80020001, }; }; @@ -57,7 +57,7 @@ struct R { ref2 = 0x7f040003, // From feature - number3 = 0x7f090000, + number3 = 0x80030000, }; }; diff --git a/libs/androidfw/tests/data/feature/AndroidManifest.xml b/libs/androidfw/tests/data/feature/AndroidManifest.xml index c972372508be3..12ca5b6fcfd6e 100644 --- a/libs/androidfw/tests/data/feature/AndroidManifest.xml +++ b/libs/androidfw/tests/data/feature/AndroidManifest.xml @@ -15,5 +15,6 @@ --> + package="com.android.basic" + featureName="feature"> diff --git a/libs/androidfw/tests/data/feature/build b/libs/androidfw/tests/data/feature/build index 6ed3e416fb103..aa2f7169345cd 100755 --- a/libs/androidfw/tests/data/feature/build +++ b/libs/androidfw/tests/data/feature/build @@ -19,4 +19,10 @@ set -e PATH_TO_FRAMEWORK_RES=${ANDROID_BUILD_TOP}/prebuilts/sdk/current/android.jar -aapt package -M AndroidManifest.xml -S res -I $PATH_TO_FRAMEWORK_RES --feature-of ../basic/basic.apk -F feature.apk -f +aapt2 compile --dir res -o compiled.flata +aapt2 link -o feature.apk \ + --manifest AndroidManifest.xml \ + -I $PATH_TO_FRAMEWORK_RES \ + -I ../basic/basic.apk \ + --package-id 0x80 \ + compiled.flata diff --git a/libs/androidfw/tests/data/feature/feature.apk b/libs/androidfw/tests/data/feature/feature.apk index 767fed697034c..a0dae380018b6 100644 Binary files a/libs/androidfw/tests/data/feature/feature.apk and b/libs/androidfw/tests/data/feature/feature.apk differ diff --git a/libs/androidfw/tests/data/feature/res/values/values.xml b/libs/androidfw/tests/data/feature/res/values/values.xml index 59f7d93ee3893..43e15177f4dd4 100644 --- a/libs/androidfw/tests/data/feature/res/values/values.xml +++ b/libs/androidfw/tests/data/feature/res/values/values.xml @@ -15,13 +15,12 @@ --> - - + test3 - + test4 - + 200