From 0dbe721d0aa231f790ead6f7b62de5531239fc7e Mon Sep 17 00:00:00 2001 From: Jozef BABJAK Date: Mon, 21 Feb 2011 15:55:01 +0100 Subject: [PATCH] Fixing improper boxing to Integer instead of Long. This is tricky: entry.getMessageBox() returns int, so it is by default boxed to Integer. Map.get() however accepts Objects, so it ignores the difference, but nothing is find during lookup, just because Long and Integer objects are compared using equals(), which has to lead to 'false' result. So, explicit boxning to Long is unnecessary here. Change-Id: I967a7829a8926410a00274c6b5e312e1af567299 --- core/java/com/google/android/mms/util/PduCache.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/java/com/google/android/mms/util/PduCache.java b/core/java/com/google/android/mms/util/PduCache.java index 7c3fad7b865c3..866ca1e128c62 100644 --- a/core/java/com/google/android/mms/util/PduCache.java +++ b/core/java/com/google/android/mms/util/PduCache.java @@ -235,7 +235,7 @@ public final class PduCache extends AbstractCache { } private void removeFromMessageBoxes(Uri key, PduCacheEntry entry) { - HashSet msgBox = mThreads.get(entry.getMessageBox()); + HashSet msgBox = mThreads.get(Long.valueOf(entry.getMessageBox())); if (msgBox != null) { msgBox.remove(key); }