From 0cd57a44ea43ec146722774a3f7d623eb9c9cbb3 Mon Sep 17 00:00:00 2001 From: Jeff Sharkey Date: Mon, 15 Mar 2010 15:08:12 -0700 Subject: [PATCH] Switch SelectionBuilder to accept Object[], fix NPE. Change-Id: I8d6ef1b47d89e4fc643402075f0549f4c4277a0f --- .../com/android/internal/content/SelectionBuilder.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/core/java/com/android/internal/content/SelectionBuilder.java b/core/java/com/android/internal/content/SelectionBuilder.java index 0e29411a401fd..b194756154c86 100644 --- a/core/java/com/android/internal/content/SelectionBuilder.java +++ b/core/java/com/android/internal/content/SelectionBuilder.java @@ -47,7 +47,7 @@ public class SelectionBuilder { * Append the given selection clause to the internal state. Each clause is * surrounded with parenthesis and combined using {@code AND}. */ - public SelectionBuilder append(String selection, String... selectionArgs) { + public SelectionBuilder append(String selection, Object... selectionArgs) { if (TextUtils.isEmpty(selection)) { if (selectionArgs != null && selectionArgs.length > 0) { throw new IllegalArgumentException( @@ -63,8 +63,12 @@ public class SelectionBuilder { } mSelection.append("(").append(selection).append(")"); - for (String arg : selectionArgs) { - mSelectionArgs.add(arg); + if (selectionArgs != null) { + for (Object arg : selectionArgs) { + // TODO: switch to storing direct Object instances once + // http://b/2464440 is fixed + mSelectionArgs.add(String.valueOf(arg)); + } } return this;