From a7a5ad7b7888d0e5ea6087f5e7aae04774335d4a Mon Sep 17 00:00:00 2001 From: Alex Chau Date: Wed, 11 Aug 2021 08:32:29 +0000 Subject: [PATCH] Revert "No NavigationBar layer in tablets" This reverts commit fb999dc720f15f0eddf729d0ce197647913f6c9b. Reason for revert: breaking TaplTestsLauncher3.testDevicePressMenu and testPressHomeOnAllAppsContextMenu for all foldable targetse Bug: 191660313 Change-Id: I04c9e28c92ed0cf9e822ecf4409edfc8f37c36c4 --- .../systemui/navigationbar/NavigationBarController.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/navigationbar/NavigationBarController.java b/packages/SystemUI/src/com/android/systemui/navigationbar/NavigationBarController.java index 97cd29df5ab43..543004eecb8ed 100644 --- a/packages/SystemUI/src/com/android/systemui/navigationbar/NavigationBarController.java +++ b/packages/SystemUI/src/com/android/systemui/navigationbar/NavigationBarController.java @@ -251,7 +251,8 @@ public class NavigationBarController implements Callbacks, /** @return {@code true} if taskbar is enabled, false otherwise */ private boolean initializeTaskbarIfNecessary() { - if (mIsTablet) { + boolean isShowingTaskbar = mIsTablet && mNavMode == NAV_BAR_MODE_3BUTTON; + if (isShowingTaskbar) { // Remove navigation bar when taskbar is showing, currently only for 3 button mode removeNavigationBar(mContext.getDisplayId()); mCommandQueue.addCallback(mTaskbarDelegate); @@ -260,7 +261,7 @@ public class NavigationBarController implements Callbacks, mCommandQueue.removeCallback(mTaskbarDelegate); mTaskbarDelegate.destroy(); } - return mIsTablet; + return isShowingTaskbar; } @Override @@ -331,7 +332,7 @@ public class NavigationBarController implements Callbacks, return; } - if (mIsTablet) { + if (mIsTablet && mNavMode == NAV_BAR_MODE_3BUTTON) { return; }