From bb3f774af8803fcdfbdf1a09467570339c1b7034 Mon Sep 17 00:00:00 2001
From: Jeongik Cha <jeongik@google.com>
Date: Thu, 19 Nov 2020 02:50:17 +0900
Subject: [PATCH] Add some comments about thread-safety

ParcelableHolder is not thread-safe, so add some comments about it.

Bug: 171982001
Test: N/A
Change-Id: Icea1407d7d7c262ce7ae7da384efe59de9e1dcdb
---
 core/java/android/os/ParcelableHolder.java | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/core/java/android/os/ParcelableHolder.java b/core/java/android/os/ParcelableHolder.java
index 881935dc874c3..fb1310019754f 100644
--- a/core/java/android/os/ParcelableHolder.java
+++ b/core/java/android/os/ParcelableHolder.java
@@ -63,6 +63,8 @@ import android.util.MathUtils;
  * op.y = ...;
  * ap.extension.setParcelable(op);}</pre>
  *
+ * <p class="note">ParcelableHolder is <strong>not</strong> thread-safe.</p>
+ *
  * @hide
  */
 @SystemApi
@@ -120,6 +122,7 @@ public final class ParcelableHolder implements Parcelable {
 
     /**
      * Write a parcelable into ParcelableHolder, the previous parcelable will be removed.
+     * (@link #setParcelable} and (@link #getParcelable} are not thread-safe.
      * @throws BadParcelableException if the parcelable's stability is more unstable
      *         ParcelableHolder.
      */
@@ -139,6 +142,8 @@ public final class ParcelableHolder implements Parcelable {
     }
 
     /**
+     * Read a parcelable from ParcelableHolder.
+     * (@link #setParcelable} and (@link #getParcelable} are not thread-safe.
      * @return the parcelable that was written by {@link #setParcelable} or {@link #readFromParcel},
      *         or {@code null} if the parcelable has not been written.
      * @throws BadParcelableException if T is different from the type written by