From 0c29f39c8eb6677ad81154b9cbc3beb95433f221 Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Thu, 20 Dec 2018 13:51:01 -0800 Subject: [PATCH] Fix/suppress libs/* google-explicit-constructor warnings * Add explicit to conversion constructors/operators Bug: 28341362 Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,google-explicit-constructor Change-Id: I31d45e4c6ff9fa69801a14c341f2da66baf565a0 --- libs/input/PointerController.cpp | 2 +- libs/protoutil/include/android/util/EncodedBuffer.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libs/input/PointerController.cpp b/libs/input/PointerController.cpp index 0a90f85cda0e0..6c5f20c1d4162 100644 --- a/libs/input/PointerController.cpp +++ b/libs/input/PointerController.cpp @@ -39,7 +39,7 @@ protected: virtual ~WeakLooperCallback() { } public: - WeakLooperCallback(const wp& callback) : + explicit WeakLooperCallback(const wp& callback) : mCallback(callback) { } diff --git a/libs/protoutil/include/android/util/EncodedBuffer.h b/libs/protoutil/include/android/util/EncodedBuffer.h index c84de4c1c0834..0b7f6e46be659 100644 --- a/libs/protoutil/include/android/util/EncodedBuffer.h +++ b/libs/protoutil/include/android/util/EncodedBuffer.h @@ -38,13 +38,13 @@ class EncodedBuffer { public: EncodedBuffer(); - EncodedBuffer(size_t chunkSize); + explicit EncodedBuffer(size_t chunkSize); ~EncodedBuffer(); class Pointer { public: Pointer(); - Pointer(size_t chunkSize); + explicit Pointer(size_t chunkSize); size_t pos() const; size_t index() const; @@ -161,7 +161,7 @@ public: friend class iterator; class iterator { public: - iterator(const EncodedBuffer& buffer); + explicit iterator(const EncodedBuffer& buffer); /** * Returns the number of bytes written in the buffer