From 0ba9573c6766c92e6c725c365c52fb3da1a80349 Mon Sep 17 00:00:00 2001 From: Daniel Norman Date: Mon, 13 Feb 2023 13:04:03 -0800 Subject: [PATCH] Use a generic label & icon for the assistant shortcut. Bug: 268747562 Test: Open A11yMenu on generic phone & tablet devices, inspect icon and use TB to speak the label. Change-Id: I093ec0a923028149549e2b138d9d28b918cb60af --- .../res/drawable-night/a11ymenu_intro.xml | 90 +++++ .../drawable-sw600dp-night/a11ymenu_intro.xml | 358 +++++------------- .../res/drawable-sw600dp/a11ymenu_intro.xml | 224 +++++------ .../res/drawable/a11ymenu_intro.png | Bin 7033 -> 0 bytes .../res/drawable/a11ymenu_intro.xml | 90 +++++ .../drawable/ic_logo_a11y_assistant_24dp.xml | 10 + .../res/drawable/ic_logo_assistant_32dp.xml | 8 - .../res/values-night/colors.xml | 2 +- .../accessibilitymenu/res/values/colors.xml | 2 +- .../accessibilitymenu/res/values/strings.xml | 2 +- .../model/A11yMenuShortcut.java | 2 +- 11 files changed, 381 insertions(+), 407 deletions(-) create mode 100644 packages/SystemUI/accessibility/accessibilitymenu/res/drawable-night/a11ymenu_intro.xml delete mode 100644 packages/SystemUI/accessibility/accessibilitymenu/res/drawable/a11ymenu_intro.png create mode 100644 packages/SystemUI/accessibility/accessibilitymenu/res/drawable/a11ymenu_intro.xml create mode 100644 packages/SystemUI/accessibility/accessibilitymenu/res/drawable/ic_logo_a11y_assistant_24dp.xml delete mode 100644 packages/SystemUI/accessibility/accessibilitymenu/res/drawable/ic_logo_assistant_32dp.xml diff --git a/packages/SystemUI/accessibility/accessibilitymenu/res/drawable-night/a11ymenu_intro.xml b/packages/SystemUI/accessibility/accessibilitymenu/res/drawable-night/a11ymenu_intro.xml new file mode 100644 index 0000000000000..b2a0b320cc0fa --- /dev/null +++ b/packages/SystemUI/accessibility/accessibilitymenu/res/drawable-night/a11ymenu_intro.xml @@ -0,0 +1,90 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/packages/SystemUI/accessibility/accessibilitymenu/res/drawable-sw600dp-night/a11ymenu_intro.xml b/packages/SystemUI/accessibility/accessibilitymenu/res/drawable-sw600dp-night/a11ymenu_intro.xml index 7a4fbb207188e..cb2e9745132bc 100644 --- a/packages/SystemUI/accessibility/accessibilitymenu/res/drawable-sw600dp-night/a11ymenu_intro.xml +++ b/packages/SystemUI/accessibility/accessibilitymenu/res/drawable-sw600dp-night/a11ymenu_intro.xml @@ -3,274 +3,104 @@ android:height="300dp" android:viewportWidth="412" android:viewportHeight="300"> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + android:strokeColor="#5f6368"/> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + android:strokeColor="#5f6368"/> + android:pathData="M78.55,70.3h0c8.84,0 16,7.16 16,16h0c0,8.84 -7.16,16 -16,16h0c-8.84,0 -16,-7.16 -16,-16h0c0,-8.84 7.16,-16 16,-16Z" + android:fillColor="#2197f3"/> + android:pathData="M78.55,174.3h0c8.83,0 16,7.16 16,16h0c0,8.83 -7.16,16 -16,16h0c-8.83,0 -16,-7.16 -16,-16h0c0,-8.83 7.16,-16 16,-16Z" + android:fillColor="#fdd663"/> + + + + + + + + + + + + + + + + + + + diff --git a/packages/SystemUI/accessibility/accessibilitymenu/res/drawable-sw600dp/a11ymenu_intro.xml b/packages/SystemUI/accessibility/accessibilitymenu/res/drawable-sw600dp/a11ymenu_intro.xml index f0fbc48691b85..aba9581894a62 100644 --- a/packages/SystemUI/accessibility/accessibilitymenu/res/drawable-sw600dp/a11ymenu_intro.xml +++ b/packages/SystemUI/accessibility/accessibilitymenu/res/drawable-sw600dp/a11ymenu_intro.xml @@ -3,139 +3,101 @@ android:height="300dp" android:viewportWidth="412" android:viewportHeight="300"> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + android:strokeColor="#e8eaed"/> + android:strokeWidth="1" + android:pathData="M126.81,222.54L126.81,250.27" + android:fillColor="#00000000" + android:strokeColor="#e8eaed"/> + android:pathData="M78.71,173.91h0c8.83,0 16,7.16 16,16h0c0,8.83 -7.16,16 -16,16h0c-8.83,0 -16,-7.16 -16,-16h0c0,-8.83 7.16,-16 16,-16Z" + android:fillColor="#de9834"/> + + + + + + + + + + + + + + + + + + + diff --git a/packages/SystemUI/accessibility/accessibilitymenu/res/drawable/a11ymenu_intro.png b/packages/SystemUI/accessibility/accessibilitymenu/res/drawable/a11ymenu_intro.png deleted file mode 100644 index 6149ee4b2365bddb0a023e09950db53ab3faaec9..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 7033 zcmb_gc|6qH`ybS_j+8F9L6&MLS&ET0s$qzsu@xnXEFVkRCVQbQ$&x8C)@F*aCCgZ| z6iG>z`B)kvgeYWBw%?h$xBI={`&(YG@9XD}bLKqfStb-8<&ajPKfD*m=Gzv^sr}T_9@mKU%Js+lKWi=k;o7IgKKMRQ{ zs>z0+-g_6`yGys7LB4v~)cX!m$J&}G>FML1amFK(jW=akq ze4$+F`k{CpOKbagtX>#?w}(hf1hzyx4E2o=K<^p{dtm=9{hWS{6!r3LSrZ5Zny!O8 zX6(iBrEAJCNQ0;5!lBaMwMfaUSDwAL9^NUvRJC4at-ZgqBXh&nEhCI0%I@a{`1G&S z!_i@ADv}yP52TAiA`lhX9sc)q80C+xu%Db5=t=Sq)?e#?Q{u_i@=GD$qR=_07@+$P zfe^a$hQF@^ffxT2I>tpj0c*fKSRO1+ip>(nvj2`IawSp-s8tU3=mZUNczsPrDlj}6 zpo?+B)%0U$VVC11M90scH*yM}hNFuvLmoId4JsGLuAYR`dD)ioY*~B^x3UG{LNzE0 znVL=@N)n4o=h20$CWg`GmB87dE=q!9PkoypmWSbO*08~8q&wNQB554hH&-=sXWH0i zsN^se_=v$v=_g?^dsm_BZ_LjvP)&2uVdmjkxhTuiRf?$|yRhv#?N=DPR%a5I)Q-|8Ad~wZZBo@c~TFj;iXV$sspWO$wX9d!w zA{6?fzfj~Zbq>6}|Ba7ALsH`iDqG9)8Cob@ZerT@KHOPwQoW^`X;vkmCIPOP0B*vg&7T@pN7cDKL#+Kl0Ahi@gk zG?Hu`J>j9*sne?$b6u)wafi$MRg|^H&x8?!G5W4cb}!on+YZ@yK3GW+*;m)^D@G&n z0D<&pk=aUVI^W+ssAHfh^A+d@mOOXgZ}*5QTQ9-|g~|H;vMKgrj&6h{e^jvxg}t%y zA{^sm%NchduH4jqzYB8}SGZD{v3(boYK=psZVz74M!!KxytzctwY)2A&~1AzS2!Tu z4#dO5*eOGn@r1S+_QghysO9?1cpGF}!(rSz80)SYamDwLFSchb&W|k56Xf)7qgy9v zw*1}0N_5?&t%4odXqKHuM_~UhD>#g_8>{Do99e1{YD>lFRD@EwpvbFL`_*zfwl#kO zek9`wQX?|29NgBzIf*mTBZ`RyN76?6br03|>)L5W+IJFz&G~7acg%|8RxQ6C&kaxw z=h>V$92Q-D2`CrB`rkJkk~UIyQx?}XS&QHDb^P=Jv$rS%E$1u1t0-ECYjgRDYYEd1 zBX@%n)~(!d(}ka_S6e>5rVOn_(X{I5@74=uG$zRj>BfYxY#v-YsFmHF_sXp-{!#2B zdO~!LKRz;ysC%Vsuw6MBbCoJ-z8w|F7`F*+LZ|9_%4K}=Cn!iF!XWC0@$T@unXJK%zl}L1B9Y$-iwoR(8M0c z&(elldUaA}9wbj?%NRzaTUyVSJFR6UYXOIYErL3RXv2^5^71-QHp@(!WWSNC3T!Va z2tDPyP3MEZ(D88RaSInhuC1*)mcPcOnz-j8yrWdcMcq<8X%1c(8Kqs>BK=9?DV^3V zJ?Q1-G+Pmg-cGZ<>TgRU`LD>2ChS&)%JfC~OF7CoC)6O^)0G=p%rCJ~ogbU3?q6Cg z6id`3I(9^{-u1?^ggwMSB0otGjkpp0lVDf@Aa`Q8m$GY|B zoF2o&B3p_gs2z_hQ#E$u2q9%FARKFm9D2gmG_w+u;o4~Yy`qzT2v{@>uJwDIcA7rc z?LNArizIj?hPf}mlM`>PpcnB-@HsIoPoy%3< zq^o_YJ6i-6NdA>o1k1L^N2*El%z-cBt*umBa{4JhLq@HgKCe-UWwAaXR8Xx;8RV(S z2GSGkQS>1NRGjZK?7baJoasGL+()!>#dEZ_9w{==Ab(CxoLLcwz7+nQ_~cx7@mnot za%HN^lhOt9Cs0K)My~UaR9W(x&KH51C#q08m2R>xwe7;k)HYYpL*`dv8oV1lX6MDr zSYOIs5XqWE@}ud=^OJH53F1c$B0t#^6W=uTHV!DzM(pQmp&{C6bqwBI zNjN!_Oq$A@82o5;nJfkx-jTuN5w8!nL|rw>m0kk@Mr7ZTcWfq8v~NkL?nsei)~+wJ znELfXM+zN?W?4SU(7l7FQA$$>Y3_n$RmDI+?MX_NN7mU)cl}A zIgU}|zQ@fkSbNcpi6)0$m#7nuEZ#SyZaeaPQjHi_s5-6_3 z6I@z@n)rIg`#Sx}p5Nx9@b=xsTJMXUH6}I`#4*3Ri(de(Ll}G89Z?wjPOk8shNxtw zTvNFw!G+jpoEJCeQETAIwxA9LjnYDgw{%*GYh7M@1syNrU~tw#L||kOj*ymWCH>B+ z6(b@Eu~O}AOu`xy>w%Cg#EF$va#Qw>TzXC5T_9&+V>}&}b(nXFdz7`{H$wJ@)zQ^K zIgQx$6jLfhya~v9uuXx}9`_{51~ZGU0M({X_hn9jUQ7BNJM&aqksjQ{I-{!1;khKl zxZC<$;(`qvRvb-PZO zYBzuheRykEf8j1|omFB-(EWleML($&O%TTk&8F*^E9oxR@0#9JkTEt)`5gMRY6mzU zZZwvOEnS?|@cw#XCPIF2XK2FjD)~PpYE(>aa>fuAm2adwbQe1ur&l^is|i$A7J9n?b%HU@3Tl_~mj z(jkCdz!!toM*W9GB$zD_lFiR z0oygPw51UDO7|BrSGQK0!U(GExDv)y zDV>Yp?(+Z`cFr6(^So1P3^c43CD1wE(fBs%s!F{}f8Wy_FS7%Co!(B;x>t&0>M!l` zi39>otY7lLDO_$*;jOx%cy9To{Y0*5yz}Le@g4UsvYc0*0_Jx#g-+6Wp~;6SB==|$ zNMoLE79kt1D?46bUr2d;`NA^7GO2y}bh~;tr>i za;heu%A-gGn}Tn%HElFLDspcWg>j;|I>0zW@BXwmZTviq$;G1GrE_@G6t+! zk;$($kISo;#vWEnlfe;HY(@F7YggLms-+QWQ-e$NCVZWGz-#O5=uIcGq-f;PVX^B%m?w*Y_nL z1hJ6Re6-;-Y?Fz9ACdpEVkp}iv!pIL_tE1+EJd+0nsRH2PlJj)Cjn*qeZNJ~n*{%g zs5F?|nO+n=fCFi6jhJhE|0qv*Y@|IrJDBb-)OxGILs6(@km#OC16iNaAoHNt+)9UEbj`GkhWAm zSi#7Yqe$5eHdCX4`ve*L*mO+CMLqpZdYy)YOly|4@nJkLZ4{BPSERA%tnV9&GO)z! zTYF4u#bcSC9;*VDiH<6H+@u17iZZiOdvrfA7NJP^IRuO)=?>?I!J` z>M%xS?Dbxb#f&AS<|Mkm7_%^a zebDuEJgM8i(}NceOK-(B5nkl@SpHi_83;p9i$K~|tBJ|VdjWEwftX!mSkQjc`kL|o z(x?BMrnvRbPX9mj=pQZl|LW18m;dXvA^DFh16&3Fc4dI8;OCWbVN%~%aO9riEnYkA za4F7{d^NMP~)65swIdKw(T(Vn&`5673dy<;+15o4!=Z`o^iBc&_)3HM>W9 zej8@)uwmJINAF;0XuyWTlVdu557L`tq$XLs#0XBD6sph9JV-Cm*wzUrwULK$)YfC_ zMS?;-h%ctjDS&S?+r`XWIK70d?wNDc8CJ^oTQ!lEdg<|weQ_z4 zY5Om?l8xd-quMhfPfPkQzRQO|v~fuVMN=iiclU)`PdO}zF_zJcbAlzB?087$;ymug zD7*3xw=pqm5)ioWB(<8<*NqLDEO6%vIvNP95MgkUL}=v-hddGz{{7LYVNa zI8Lf>D8iRph~ zu*&GOO!SJ<)8d?K6DkahXZ(@$aBx!JCPxC=GVi)8N3-zXuEyT?Y3*2M=qGaR#p z6BWkrg;rlzrq;9(2lop_3kzkcg`uCE2hEx_ zH_7hBTeKp@`;;HBlGXyIKXz->sBHGa2P%5uk4cC?PYGkkVFfBOhacO!q_iCjyEcTO zFWaX^v4Vl5W|R76x96?(`3F)EOf8wC1_babki_RkGK(Je+YfA#b#~!T_4C~W0pnz! zxHx%16F*Q-=Y8;jn~7WWaMMybVO5nlU0- z+16xgeS$*So7czT>vJ^B9M=W20G53MZHFi*67pYPM@3y2yO!hc)bZQ1dKzy_X@i2m zoc-hbBD76Q6L#zYB64#hmeBg76h$tRI~pJj6gV|>UvJT?AtAGi><_f9eu0v-<*?ed zN|q6oO(n|XaO5lYxzc@ z>ktT8o*UmwQj*kXkjJn8eAjmT)%A+Se?6>!JdXeOxA6FX@-)xAgYN7V8Yza>aR}P- zAs6$SHtp_Ni!-4dFw2{AZ_hgHR4wy%`!Z9u2K{#+58!=&0C|66fIr~Ae_(-cYV{I4Fp%23X6^{K&G(ngjSbitMu@K7q6a3M zM-kQ5B8uNv@i7|G78 z04KmdBe(qs@XKGSG{H~gEtVlaKsJBJK)Siv$*fHv7}7*~0_-CKamf>4fM>HOWf4gH zGHVkF5*7vw9Y@B?$*k$mouTw+dm-J(@?sbM%H^EAYz!nD0H2IBrzs5UYUbtvKXh_C z<{H}!p!=-MITK!Nh&c3e7=5TlKQ|L>R-~T5jh8}$c!2)OSuQCtEEkR-qX~cTgx#X+{d%(!;FESy^(j>3;=ad9S>fhIhc!{t zx{+F=;ViSnjy`c7Y(wxPmf`NM%;aOiJ3*aS7&=o_%+Bhr+();EO_4=7$!?Iqc6*C7jvlIsCTfCO{4)9Z z=!;~a#3&#;izMYL3*hmOg+ynmBo;c?lb^v&?TCil`|E~lj}c&zYJxAFWs=BOL4S7N z$*F(ytXM~B$s_hcGw;gDRuCaAYrM7MH~kU5N(<%(S%}G3`RK}F$61A7^m2m=)@HnC z*z1%L`~knNb5M^hj7__$Tje*tOp7dQX_ diff --git a/packages/SystemUI/accessibility/accessibilitymenu/res/drawable/a11ymenu_intro.xml b/packages/SystemUI/accessibility/accessibilitymenu/res/drawable/a11ymenu_intro.xml new file mode 100644 index 0000000000000..a5a05351eba6f --- /dev/null +++ b/packages/SystemUI/accessibility/accessibilitymenu/res/drawable/a11ymenu_intro.xml @@ -0,0 +1,90 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/packages/SystemUI/accessibility/accessibilitymenu/res/drawable/ic_logo_a11y_assistant_24dp.xml b/packages/SystemUI/accessibility/accessibilitymenu/res/drawable/ic_logo_a11y_assistant_24dp.xml new file mode 100644 index 0000000000000..9c3417fde80a8 --- /dev/null +++ b/packages/SystemUI/accessibility/accessibilitymenu/res/drawable/ic_logo_a11y_assistant_24dp.xml @@ -0,0 +1,10 @@ + + + \ No newline at end of file diff --git a/packages/SystemUI/accessibility/accessibilitymenu/res/drawable/ic_logo_assistant_32dp.xml b/packages/SystemUI/accessibility/accessibilitymenu/res/drawable/ic_logo_assistant_32dp.xml deleted file mode 100644 index ebeebf81eedcf..0000000000000 --- a/packages/SystemUI/accessibility/accessibilitymenu/res/drawable/ic_logo_assistant_32dp.xml +++ /dev/null @@ -1,8 +0,0 @@ - - - - - - diff --git a/packages/SystemUI/accessibility/accessibilitymenu/res/values-night/colors.xml b/packages/SystemUI/accessibility/accessibilitymenu/res/values-night/colors.xml index a600ec6bbccf1..fbf2b071ea3cf 100644 --- a/packages/SystemUI/accessibility/accessibilitymenu/res/values-night/colors.xml +++ b/packages/SystemUI/accessibility/accessibilitymenu/res/values-night/colors.xml @@ -9,7 +9,7 @@ #7ae3d4 #f496ac #adcbff - #F1F3F4 + #adcbff #fdd663 #10FFFFFF diff --git a/packages/SystemUI/accessibility/accessibilitymenu/res/values/colors.xml b/packages/SystemUI/accessibility/accessibilitymenu/res/values/colors.xml index c1494f9c8103c..d81d0d511a872 100644 --- a/packages/SystemUI/accessibility/accessibilitymenu/res/values/colors.xml +++ b/packages/SystemUI/accessibility/accessibilitymenu/res/values/colors.xml @@ -9,7 +9,7 @@ #01A2A0 #F15B8D #26459C - #F1F3F4 + #2196F3 #E59810 #1a73e8 diff --git a/packages/SystemUI/accessibility/accessibilitymenu/res/values/strings.xml b/packages/SystemUI/accessibility/accessibilitymenu/res/values/strings.xml index 30fd0173ff3fc..0747ef089a8d9 100644 --- a/packages/SystemUI/accessibility/accessibilitymenu/res/values/strings.xml +++ b/packages/SystemUI/accessibility/accessibilitymenu/res/values/strings.xml @@ -10,7 +10,7 @@ Assistant - Google Assistant + Assistant Accessibility Settings diff --git a/packages/SystemUI/accessibility/accessibilitymenu/src/com/android/systemui/accessibility/accessibilitymenu/model/A11yMenuShortcut.java b/packages/SystemUI/accessibility/accessibilitymenu/src/com/android/systemui/accessibility/accessibilitymenu/model/A11yMenuShortcut.java index b6328f04ac2ef..66a2fae0c4c34 100644 --- a/packages/SystemUI/accessibility/accessibilitymenu/src/com/android/systemui/accessibility/accessibilitymenu/model/A11yMenuShortcut.java +++ b/packages/SystemUI/accessibility/accessibilitymenu/src/com/android/systemui/accessibility/accessibilitymenu/model/A11yMenuShortcut.java @@ -54,7 +54,7 @@ public class A11yMenuShortcut { /** Map stores all shortcut resource IDs that is in matching order of defined shortcut. */ private static final Map sShortcutResource = new HashMap<>() {{ put(ShortcutId.ID_ASSISTANT_VALUE, new int[] { - R.drawable.ic_logo_assistant_32dp, + R.drawable.ic_logo_a11y_assistant_24dp, R.color.assistant_color, R.string.assistant_utterance, R.string.assistant_label,