From 0ba0d814b300e9dea70933885c1837695eda69da Mon Sep 17 00:00:00 2001 From: Fyodor Kupolov Date: Fri, 24 Feb 2017 12:46:37 -0800 Subject: [PATCH] Don't log privapp-permissions violations for updated apps Only warn about violations in non-updated apps. If an updated privileged app started requesting a new privileged permission, it cannot be whitelisted on system image, so we should revoke it as before, but not log. Test: manual Bug: 35633526 Change-Id: I6aacaed4be7bf6eaef08ea81ea49cd250c81e71e --- .../core/java/com/android/server/pm/PackageManagerService.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/services/core/java/com/android/server/pm/PackageManagerService.java b/services/core/java/com/android/server/pm/PackageManagerService.java index 85911534e39c0..ef8484a13b598 100644 --- a/services/core/java/com/android/server/pm/PackageManagerService.java +++ b/services/core/java/com/android/server/pm/PackageManagerService.java @@ -11662,7 +11662,8 @@ public class PackageManagerService extends IPackageManager.Stub { if (!whitelisted) { Slog.w(TAG, "Privileged permission " + perm + " for package " + pkg.packageName + " - not in privapp-permissions whitelist"); - if (!mSystemReady) { + // Only report violations for apps on system image + if (!mSystemReady && !pkg.isUpdatedSystemApp()) { if (mPrivappPermissionsViolations == null) { mPrivappPermissionsViolations = new ArraySet<>(); }