From 0b9ac5a20fea57fe438b29265b12ce270a69df49 Mon Sep 17 00:00:00 2001 From: Robert Carr Date: Wed, 26 Oct 2016 14:12:14 -0700 Subject: [PATCH] Disable seamless rotation when nav bar jumps. When the nav bar visually moves on rotation, we want to disable seamless rotation. We could investigate later if it could be made to work. Test: Try rotating camera video view on tablet. Bug: 31817280 Change-Id: Ie13d7eaafd8bb66c8db574cd81d76fa9ca860e51 --- .../java/com/android/server/policy/PhoneWindowManager.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/services/core/java/com/android/server/policy/PhoneWindowManager.java b/services/core/java/com/android/server/policy/PhoneWindowManager.java index b8b16d5acdce2..819deeb666c83 100644 --- a/services/core/java/com/android/server/policy/PhoneWindowManager.java +++ b/services/core/java/com/android/server/policy/PhoneWindowManager.java @@ -7919,6 +7919,12 @@ public class PhoneWindowManager implements WindowManagerPolicy { if (oldRotation == mUpsideDownRotation || newRotation == mUpsideDownRotation) { return false; } + // If the navigation bar can't change sides, then it will + // jump when we change orientations and we don't rotate + // seamlessly. + if (!mNavigationBarCanMove) { + return false; + } int delta = newRotation - oldRotation; if (delta < 0) delta += 4; // Likewise we don't rotate seamlessly for 180 degree rotations