From 0b5a0200c4aef1866142c5dadd9a45b315ff0265 Mon Sep 17 00:00:00 2001 From: Fedor Kudasov Date: Tue, 7 Dec 2021 11:57:11 +0000 Subject: [PATCH] Initialize TileRecord members in constructor Bug: 209459024 Test: m SystemUI-core Change-Id: I18a73b63552181c0b9b9034563b15eb062e44707 --- .../com/android/systemui/qs/QSPanelControllerBase.java | 10 +++++++--- .../src/com/android/systemui/qs/TileLayoutTest.java | 7 +++---- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/qs/QSPanelControllerBase.java b/packages/SystemUI/src/com/android/systemui/qs/QSPanelControllerBase.java index eddc206db231a..d470fa242f713 100644 --- a/packages/SystemUI/src/com/android/systemui/qs/QSPanelControllerBase.java +++ b/packages/SystemUI/src/com/android/systemui/qs/QSPanelControllerBase.java @@ -219,9 +219,8 @@ public abstract class QSPanelControllerBase extends ViewContr } private void addTile(final QSTile tile, boolean collapsedView) { - final TileRecord r = new TileRecord(); - r.tile = tile; - r.tileView = mHost.createTileView(getContext(), tile, collapsedView); + final TileRecord r = + new TileRecord(tile, mHost.createTileView(getContext(), tile, collapsedView)); mView.addTile(r); mRecords.add(r); mCachedSpecs = getTilesSpecs(); @@ -418,6 +417,11 @@ public abstract class QSPanelControllerBase extends ViewContr /** */ public static final class TileRecord extends QSPanel.Record { + public TileRecord(QSTile tile, com.android.systemui.plugins.qs.QSTileView tileView) { + this.tile = tile; + this.tileView = tileView; + } + public QSTile tile; public com.android.systemui.plugins.qs.QSTileView tileView; public boolean scanState; diff --git a/packages/SystemUI/tests/src/com/android/systemui/qs/TileLayoutTest.java b/packages/SystemUI/tests/src/com/android/systemui/qs/TileLayoutTest.java index 24e47c5159a00..bd4bfff4c18a1 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/qs/TileLayoutTest.java +++ b/packages/SystemUI/tests/src/com/android/systemui/qs/TileLayoutTest.java @@ -58,10 +58,9 @@ public class TileLayoutTest extends SysuiTestCase { } private QSPanelControllerBase.TileRecord createTileRecord() { - QSPanelControllerBase.TileRecord tileRecord = new QSPanelControllerBase.TileRecord(); - tileRecord.tile = mock(QSTile.class); - tileRecord.tileView = spy(new QSTileViewImpl(mContext, new QSIconViewImpl(mContext))); - return tileRecord; + return new QSPanelControllerBase.TileRecord( + mock(QSTile.class), + spy(new QSTileViewImpl(mContext, new QSIconViewImpl(mContext)))); } @Test