Merge "RESTRICT AUTOMERGE" into pi-dev

This commit is contained in:
Linus Tufvesson
2020-04-02 13:31:56 +00:00
committed by Android (Google) Code Review
2 changed files with 7 additions and 17 deletions

View File

@@ -25,18 +25,18 @@ import android.content.res.Resources;
import android.hardware.display.DisplayManager; import android.hardware.display.DisplayManager;
import android.hardware.display.DisplayManager.DisplayListener; import android.hardware.display.DisplayManager.DisplayListener;
import android.os.Binder; import android.os.Binder;
import android.os.Handler;
import android.os.IBinder; import android.os.IBinder;
import android.os.Message;
import android.util.DisplayMetrics;
import android.util.Log;
import android.util.TypedValue;
import android.view.ContextThemeWrapper; import android.view.ContextThemeWrapper;
import android.view.Display; import android.view.Display;
import android.view.Gravity; import android.view.Gravity;
import android.view.Window; import android.view.Window;
import android.view.WindowManager; import android.view.WindowManager;
import android.view.WindowManagerImpl; import android.view.WindowManagerImpl;
import android.os.Handler;
import android.os.Message;
import android.util.DisplayMetrics;
import android.util.Log;
import android.util.TypedValue;
/** /**
* Base class for presentations. * Base class for presentations.
@@ -115,9 +115,7 @@ import android.view.WindowManagerImpl;
* The display manager keeps track of all displays in the system. However, not all * The display manager keeps track of all displays in the system. However, not all
* displays are appropriate for showing presentations. For example, if an activity * displays are appropriate for showing presentations. For example, if an activity
* attempted to show a presentation on the main display it might obscure its own content * attempted to show a presentation on the main display it might obscure its own content
* (it's like opening a dialog on top of your activity). Creating a presentation on the main * (it's like opening a dialog on top of your activity).
* display will result in {@link android.view.WindowManager.InvalidDisplayException} being thrown
* when invoking {@link #show()}.
* </p><p> * </p><p>
* Here's how to identify suitable displays for showing presentations using * Here's how to identify suitable displays for showing presentations using
* {@link DisplayManager#getDisplays(String)} and the * {@link DisplayManager#getDisplays(String)} and the
@@ -244,7 +242,7 @@ public class Presentation extends Dialog {
/** /**
* Inherited from {@link Dialog#show}. Will throw * Inherited from {@link Dialog#show}. Will throw
* {@link android.view.WindowManager.InvalidDisplayException} if the specified secondary * {@link android.view.WindowManager.InvalidDisplayException} if the specified secondary
* {@link Display} can't be found or if it does not have {@link Display#FLAG_PRESENTATION} set. * {@link Display} can't be found.
*/ */
@Override @Override
public void show() { public void show() {

View File

@@ -55,7 +55,6 @@ import static android.view.WindowManager.LayoutParams.TYPE_DREAM;
import static android.view.WindowManager.LayoutParams.TYPE_INPUT_METHOD; import static android.view.WindowManager.LayoutParams.TYPE_INPUT_METHOD;
import static android.view.WindowManager.LayoutParams.TYPE_INPUT_METHOD_DIALOG; import static android.view.WindowManager.LayoutParams.TYPE_INPUT_METHOD_DIALOG;
import static android.view.WindowManager.LayoutParams.TYPE_NAVIGATION_BAR; import static android.view.WindowManager.LayoutParams.TYPE_NAVIGATION_BAR;
import static android.view.WindowManager.LayoutParams.TYPE_PRESENTATION;
import static android.view.WindowManager.LayoutParams.TYPE_PRIVATE_PRESENTATION; import static android.view.WindowManager.LayoutParams.TYPE_PRIVATE_PRESENTATION;
import static android.view.WindowManager.LayoutParams.TYPE_QS_DIALOG; import static android.view.WindowManager.LayoutParams.TYPE_QS_DIALOG;
import static android.view.WindowManager.LayoutParams.TYPE_STATUS_BAR; import static android.view.WindowManager.LayoutParams.TYPE_STATUS_BAR;
@@ -1183,13 +1182,6 @@ public class WindowManagerService extends IWindowManager.Stub
return WindowManagerGlobal.ADD_PERMISSION_DENIED; return WindowManagerGlobal.ADD_PERMISSION_DENIED;
} }
if (type == TYPE_PRESENTATION && !displayContent.getDisplay().isPublicPresentation()) {
Slog.w(TAG_WM,
"Attempted to add presentation window to a non-suitable display. "
+ "Aborting.");
return WindowManagerGlobal.ADD_INVALID_DISPLAY;
}
AppWindowToken atoken = null; AppWindowToken atoken = null;
final boolean hasParent = parentWindow != null; final boolean hasParent = parentWindow != null;
// Use existing parent window token for child windows since they go in the same token // Use existing parent window token for child windows since they go in the same token