diff --git a/core/java/android/database/sqlite/SQLiteGlobal.java b/core/java/android/database/sqlite/SQLiteGlobal.java index 5ff199a752575..922d11b6ae65f 100644 --- a/core/java/android/database/sqlite/SQLiteGlobal.java +++ b/core/java/android/database/sqlite/SQLiteGlobal.java @@ -61,6 +61,8 @@ public final class SQLiteGlobal { public static int getDefaultPageSize() { synchronized (sLock) { if (sDefaultPageSize == 0) { + // If there is an issue accessing /data, something is so seriously + // wrong that we just let the IllegalArgumentException propagate. sDefaultPageSize = new StatFs("/data").getBlockSize(); } return SystemProperties.getInt("debug.sqlite.pagesize", sDefaultPageSize); diff --git a/core/java/android/os/StatFs.java b/core/java/android/os/StatFs.java index 13e9a15eedb63..aeffdc7847626 100644 --- a/core/java/android/os/StatFs.java +++ b/core/java/android/os/StatFs.java @@ -34,11 +34,16 @@ public class StatFs { * class. * * @param path path in the desired file system to stat. + * + * @throws IllegalArgumentException if the file system access fails */ public StatFs(String path) { mStat = doStat(path); } + /** + * @throws IllegalArgumentException if the file system access fails + */ private static StructStatVfs doStat(String path) { try { return Os.statvfs(path); @@ -51,6 +56,8 @@ public class StatFs { * Perform a restat of the file system referenced by this object. This is * the same as re-constructing the object with the same file system path, * and the new stat values are available upon return. + * + * @throws IllegalArgumentException if the file system access fails */ public void restat(String path) { mStat = doStat(path); diff --git a/services/core/java/com/android/server/storage/DeviceStorageMonitorService.java b/services/core/java/com/android/server/storage/DeviceStorageMonitorService.java index 90c711a479414..35732a34ed259 100644 --- a/services/core/java/com/android/server/storage/DeviceStorageMonitorService.java +++ b/services/core/java/com/android/server/storage/DeviceStorageMonitorService.java @@ -330,7 +330,8 @@ public class DeviceStorageMonitorService extends SystemService { mLastReportedFreeMemTime = 0; mResolver = context.getContentResolver(); mIsBootImageOnDisk = isBootImageOnDisk(); - //create StatFs object + // If these constructors throw IllegalArgumentException, something + // is so seriously wrong that we just let the Exception propagate. mDataFileStats = new StatFs(DATA_PATH.getAbsolutePath()); mSystemFileStats = new StatFs(SYSTEM_PATH.getAbsolutePath()); mCacheFileStats = new StatFs(CACHE_PATH.getAbsolutePath());