diff --git a/packages/SettingsLib/src/com/android/settingslib/media/LocalMediaManager.java b/packages/SettingsLib/src/com/android/settingslib/media/LocalMediaManager.java index e8d9212a1bc7c..20288c0e45a59 100644 --- a/packages/SettingsLib/src/com/android/settingslib/media/LocalMediaManager.java +++ b/packages/SettingsLib/src/com/android/settingslib/media/LocalMediaManager.java @@ -92,8 +92,6 @@ public class LocalMediaManager implements BluetoothCallback { @VisibleForTesting List mDisconnectedMediaDevices = new CopyOnWriteArrayList<>(); @VisibleForTesting - MediaDevice mPhoneDevice; - @VisibleForTesting MediaDevice mCurrentConnectedDevice; @VisibleForTesting DeviceAttributeChangeCallback mDeviceAttributeChangeCallback = diff --git a/packages/SettingsLib/tests/robotests/src/com/android/settingslib/media/LocalMediaManagerTest.java b/packages/SettingsLib/tests/robotests/src/com/android/settingslib/media/LocalMediaManagerTest.java index c8d186f38e5f4..d87fc5478f48c 100644 --- a/packages/SettingsLib/tests/robotests/src/com/android/settingslib/media/LocalMediaManagerTest.java +++ b/packages/SettingsLib/tests/robotests/src/com/android/settingslib/media/LocalMediaManagerTest.java @@ -266,18 +266,15 @@ public class LocalMediaManagerTest { final MediaDevice device1 = mock(MediaDevice.class); final MediaDevice device2 = mock(MediaDevice.class); final MediaDevice device3 = mock(MediaDevice.class); - mLocalMediaManager.mPhoneDevice = mock(PhoneMediaDevice.class); devices.add(device1); devices.add(device2); mLocalMediaManager.mMediaDevices.add(device3); - mLocalMediaManager.mMediaDevices.add(mLocalMediaManager.mPhoneDevice); when(device1.getId()).thenReturn(TEST_DEVICE_ID_1); when(device2.getId()).thenReturn(TEST_DEVICE_ID_2); when(device3.getId()).thenReturn(TEST_DEVICE_ID_3); - when(mLocalMediaManager.mPhoneDevice.getId()).thenReturn("test_phone_id"); - assertThat(mLocalMediaManager.mMediaDevices).hasSize(2); + assertThat(mLocalMediaManager.mMediaDevices).hasSize(1); mLocalMediaManager.registerCallback(mCallback); mLocalMediaManager.mMediaDeviceCallback.onDeviceListAdded(devices); @@ -290,14 +287,12 @@ public class LocalMediaManagerTest { final List devices = new ArrayList<>(); final MediaDevice device1 = mock(MediaDevice.class); final MediaDevice device2 = mock(MediaDevice.class); - mLocalMediaManager.mPhoneDevice = mock(PhoneMediaDevice.class); devices.add(device1); devices.add(device2); mLocalMediaManager.mMediaDevices.add(device1); mLocalMediaManager.mMediaDevices.add(device2); - mLocalMediaManager.mMediaDevices.add(mLocalMediaManager.mPhoneDevice); - assertThat(mLocalMediaManager.mMediaDevices).hasSize(3); + assertThat(mLocalMediaManager.mMediaDevices).hasSize(2); mLocalMediaManager.registerCallback(mCallback); mLocalMediaManager.mMediaDeviceCallback .onDeviceListRemoved(mLocalMediaManager.mMediaDevices); @@ -312,19 +307,17 @@ public class LocalMediaManagerTest { final MediaDevice device1 = mock(MediaDevice.class); final MediaDevice device2 = mock(MediaDevice.class); final MediaDevice device3 = mock(MediaDevice.class); - mLocalMediaManager.mPhoneDevice = mock(PhoneMediaDevice.class); devices.add(device1); devices.add(device3); mLocalMediaManager.mMediaDevices.add(device1); mLocalMediaManager.mMediaDevices.add(device2); mLocalMediaManager.mMediaDevices.add(device3); - mLocalMediaManager.mMediaDevices.add(mLocalMediaManager.mPhoneDevice); - assertThat(mLocalMediaManager.mMediaDevices).hasSize(4); + assertThat(mLocalMediaManager.mMediaDevices).hasSize(3); mLocalMediaManager.registerCallback(mCallback); mLocalMediaManager.mMediaDeviceCallback.onDeviceListRemoved(devices); - assertThat(mLocalMediaManager.mMediaDevices).hasSize(2); + assertThat(mLocalMediaManager.mMediaDevices).hasSize(1); verify(mCallback).onDeviceListUpdate(any()); } @@ -452,9 +445,7 @@ public class LocalMediaManagerTest { public void onDeviceListAdded_haveMutingExpectedDevice_addMutingExpectedDevice() { final List devices = new ArrayList<>(); final MediaDevice device1 = mock(MediaDevice.class); - mLocalMediaManager.mPhoneDevice = mock(PhoneMediaDevice.class); devices.add(device1); - devices.add(mLocalMediaManager.mPhoneDevice); final List profiles = new ArrayList<>(); final A2dpProfile a2dpProfile = mock(A2dpProfile.class); @@ -483,13 +474,12 @@ public class LocalMediaManagerTest { when(device1.getId()).thenReturn(TEST_DEVICE_ID_1); when(device1.getDeviceType()).thenReturn(MediaDevice.MediaDeviceType.TYPE_PHONE_DEVICE); - when(mLocalMediaManager.mPhoneDevice.getId()).thenReturn("test_phone_id"); assertThat(mLocalMediaManager.mMediaDevices).hasSize(0); mLocalMediaManager.registerCallback(mCallback); mLocalMediaManager.mMediaDeviceCallback.onDeviceListAdded(devices); - assertThat(mLocalMediaManager.mMediaDevices).hasSize(3); + assertThat(mLocalMediaManager.mMediaDevices).hasSize(2); verify(mCallback).onDeviceListUpdate(any()); } @@ -536,17 +526,13 @@ public class LocalMediaManagerTest { final MediaDevice device1 = mock(MediaDevice.class); final MediaDevice device2 = mock(MediaDevice.class); final MediaDevice device3 = mock(MediaDevice.class); - mLocalMediaManager.mPhoneDevice = mock(PhoneMediaDevice.class); devices.add(device1); devices.add(device2); mLocalMediaManager.mMediaDevices.add(device3); - mLocalMediaManager.mMediaDevices.add(mLocalMediaManager.mPhoneDevice); mShadowBluetoothAdapter = null; - when(mLocalMediaManager.mPhoneDevice.getId()).thenReturn("test_phone_id"); - - assertThat(mLocalMediaManager.mMediaDevices).hasSize(2); + assertThat(mLocalMediaManager.mMediaDevices).hasSize(1); mLocalMediaManager.registerCallback(mCallback); mLocalMediaManager.mMediaDeviceCallback.onDeviceListAdded(devices);