From a0d767c8226babdc23c84d685d89d279b48f6c7e Mon Sep 17 00:00:00 2001 From: Steve Block Date: Tue, 27 Sep 2011 22:39:45 +0100 Subject: [PATCH] Always call WebView.onPageStarted(), regardless of whether a WebViewClient has been set This makes sure that the page's SSL certificate is cleared when the page load starts. Follows on from https://android-git.corp.google.com/g/#/c/138147. Bug: 5287216 Change-Id: I40f74a72dc495c48d7167b7b70a845a8481feb85 --- core/java/android/webkit/CallbackProxy.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/core/java/android/webkit/CallbackProxy.java b/core/java/android/webkit/CallbackProxy.java index c9fcf0c278428..5ee90a4fdab61 100644 --- a/core/java/android/webkit/CallbackProxy.java +++ b/core/java/android/webkit/CallbackProxy.java @@ -905,11 +905,9 @@ class CallbackProxy extends Handler { */ public void onPageStarted(String url, Bitmap favicon) { - // Do an unsynchronized quick check to avoid posting if no callback has - // been set. - if (mWebViewClient == null) { - return; - } + // We need to send the message even if no WebViewClient is set, because we need to call + // WebView.onPageStarted(). + // Performance probe if (PERF_PROBE) { mWebCoreThreadTime = SystemClock.currentThreadTimeMillis();