From 6cca414de21e515e1db4164b15b33355c724cf1a Mon Sep 17 00:00:00 2001 From: Adam Lesinski Date: Thu, 25 Feb 2016 18:23:02 -0800 Subject: [PATCH] BatteryStats: Fix issue where network traffic accounting might be lost Both bytes transmitted and received must be 0 if we are to short circuit and ignore the UID's network delta. Change-Id: Ia69f605c7d5954b8f2c3671bab596dc9925f1d02 --- core/java/com/android/internal/os/BatteryStatsImpl.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/java/com/android/internal/os/BatteryStatsImpl.java b/core/java/com/android/internal/os/BatteryStatsImpl.java index 648b1a54927d5..3ea139752aaf1 100644 --- a/core/java/com/android/internal/os/BatteryStatsImpl.java +++ b/core/java/com/android/internal/os/BatteryStatsImpl.java @@ -8056,7 +8056,8 @@ public final class BatteryStatsImpl extends BatteryStats { + " txPackets=" + entry.txPackets); } - if (entry.rxBytes == 0 || entry.txBytes == 0) { + if (entry.rxBytes == 0 && entry.txBytes == 0) { + // Skip the lookup below since there is no work to do. continue; }