From 0993fbd81cbac381ebb5470f1fa0fd1a95daec39 Mon Sep 17 00:00:00 2001 From: Prince Date: Mon, 6 Mar 2023 15:20:52 +0000 Subject: [PATCH] Null checking window before starting dream With window being null we get null exception when trying to get attributes to properly start dream Test: atest DreamServiceTest Bug: b/271179864 Change-Id: I3136b620383a0c609a8260cc7b0e9b7f6e6422c1 --- core/java/android/service/dreams/DreamService.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/core/java/android/service/dreams/DreamService.java b/core/java/android/service/dreams/DreamService.java index d79ea8929047e..224307297e765 100644 --- a/core/java/android/service/dreams/DreamService.java +++ b/core/java/android/service/dreams/DreamService.java @@ -1409,6 +1409,10 @@ public class DreamService extends Service implements Window.Callback { // Request the DreamOverlay be told to dream with dream's window // parameters once the window has been attached. mDreamStartOverlayConsumer = overlay -> { + if (mWindow == null) { + Slog.d(TAG, "mWindow is null"); + return; + } try { overlay.startDream(mWindow.getAttributes(), mOverlayCallback, mDreamComponent.flattenToString(),