From 787a0af8ebba004a6f1cd3bfe8c78d851003d227 Mon Sep 17 00:00:00 2001 From: Jorim Jaggi Date: Wed, 4 Jun 2014 18:57:14 +0200 Subject: [PATCH] Fix not being able to dismiss notifications with tap. Also fixes that the go-to-shade gesture sometimes triggers the unlock hint animation. Bug: 14487435 Bug: 15421928 Change-Id: Ie7e01c81a397b9b1a03baed82c1270ba4e7eb799 --- packages/SystemUI/src/com/android/systemui/ExpandHelper.java | 2 +- .../src/com/android/systemui/statusbar/phone/PanelView.java | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/ExpandHelper.java b/packages/SystemUI/src/com/android/systemui/ExpandHelper.java index e5e3a1a40fa9d..006619b36719b 100644 --- a/packages/SystemUI/src/com/android/systemui/ExpandHelper.java +++ b/packages/SystemUI/src/com/android/systemui/ExpandHelper.java @@ -437,7 +437,7 @@ public class ExpandHelper implements Gefingerpoken { break; } mLastMotionY = ev.getRawY(); - return true; + return mResizedView != null; } /** diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/PanelView.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/PanelView.java index 5442bc966d23a..89a19076b1e08 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/PanelView.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/PanelView.java @@ -162,7 +162,7 @@ public abstract class PanelView extends FrameLayout { if (mHeightAnimator != null) { mHeightAnimator.cancel(); // end any outstanding animations } - mTouchSlopExceeded = true; + mTouchSlopExceeded = (mHeightAnimator != null && !mHintAnimationRunning); onTrackingStarted(); } if (mExpandedHeight == 0) { @@ -219,7 +219,8 @@ public abstract class PanelView extends FrameLayout { case MotionEvent.ACTION_CANCEL: mTrackingPointer = -1; trackMovement(event); - if (mTracking && mTouchSlopExceeded) { + if ((mTracking && mTouchSlopExceeded) + || event.getActionMasked() == MotionEvent.ACTION_CANCEL) { float vel = getCurrentVelocity(); boolean expand = flingExpands(vel); onTrackingStopped(expand);