From aa19b22208e11335fda6efea13402b55bec1921f Mon Sep 17 00:00:00 2001 From: Eric Biggers Date: Mon, 22 May 2023 17:41:04 +0000 Subject: [PATCH] Log errors in verifyChallengeInternal() It is unexpected for verifyChallengeInternal() to fail, since the Gatekeeper enrollment of the synthetic password (more specifically, the Gatekeeper password derived from the synthetic password) should always be valid. Therefore, ensure that an error message is logged in all failure cases. Bug: 282947979 Change-Id: Ic8d0134bc4f3e0979bf500ffb5a99f2522251d39 Merged-In: Ic8d0134bc4f3e0979bf500ffb5a99f2522251d39 (cherry picked from commit b60583c3b12864e69f10dc01046d898d85b2083a) --- .../android/server/locksettings/SyntheticPasswordManager.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/services/core/java/com/android/server/locksettings/SyntheticPasswordManager.java b/services/core/java/com/android/server/locksettings/SyntheticPasswordManager.java index 3f66fee2f86b8..f27b913585fd6 100644 --- a/services/core/java/com/android/server/locksettings/SyntheticPasswordManager.java +++ b/services/core/java/com/android/server/locksettings/SyntheticPasswordManager.java @@ -1327,8 +1327,10 @@ public class SyntheticPasswordManager { } return result; } else if (responseCode == GateKeeperResponse.RESPONSE_RETRY) { + Slog.e(TAG, "Gatekeeper verification of synthetic password failed with RESPONSE_RETRY"); return VerifyCredentialResponse.fromTimeout(response.getTimeout()); } else { + Slog.e(TAG, "Gatekeeper verification of synthetic password failed with RESPONSE_ERROR"); return VerifyCredentialResponse.ERROR; } }