Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ignore some Chooser tests that flake on races.

Browse Source 
As described in b/222124533, the reliability of these tests
can be improved with a timeout, but that's still not a very
solid fix. We should just ignore them for now so they stop
breaking on the monitor, and meanwhile I'll continue
investigating the root cause.

Bug: 222124533, 220337209, 220959679, 218218953
Test: disabling tests only
Change-Id: I113a1ba4de2176e209339a1cbbe2583cb5fe518c
Merged-In: I113a1ba4de2176e209339a1cbbe2583cb5fe518c
(cherry picked from commit 2864475fd7)
This commit is contained in:
Joshua Trask
2022-03-02 11:49:28 -05:00
committed by Matt Casey
parent 31cc9ddb59
commit 08df009e8d
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
core/tests/coretests/src/com/android/internal/app/ChooserActivityTest.java
View File

@@ -81,7 +81,6 @@ import android.net.Uri;
import android.os.UserHandle; import android.os.UserHandle;
import android.provider.DeviceConfig; import android.provider.DeviceConfig;
import android.service.chooser.ChooserTarget; import android.service.chooser.ChooserTarget;
import android.util.Log;
import android.view.View; import android.view.View;
import androidx.annotation.CallSuper; import androidx.annotation.CallSuper;
@@ -2024,7 +2023,7 @@ public class ChooserActivityTest {
.check(matches(isDisplayed())); .check(matches(isDisplayed()));
} }
@Test @Test @Ignore("b/222124533")
public void testAppTargetLogging() throws InterruptedException { public void testAppTargetLogging() throws InterruptedException {
Intent sendIntent = createSendTextIntent(); Intent sendIntent = createSendTextIntent();
List<ResolvedComponentInfo> resolvedComponentInfos = createResolvedComponentsForTest(2); List<ResolvedComponentInfo> resolvedComponentInfos = createResolvedComponentsForTest(2);
@@ -2043,6 +2042,10 @@ public class ChooserActivityTest {
mActivityRule.launchActivity(Intent.createChooser(sendIntent, null)); mActivityRule.launchActivity(Intent.createChooser(sendIntent, null));
waitForIdle(); waitForIdle();
// TODO(b/222124533): other test cases use a timeout to make sure that the UI is fully
// populated; without one, this test flakes. Ideally we should address the need for a
// timeout everywhere instead of introducing one to fix this particular test.
assertThat(activity.getAdapter().getCount(), is(2)); assertThat(activity.getAdapter().getCount(), is(2));
onView(withIdFromRuntimeResource("profile_button")).check(doesNotExist()); onView(withIdFromRuntimeResource("profile_button")).check(doesNotExist());
@@ -2325,7 +2328,7 @@ public class ChooserActivityTest {
assertThat(logger.numCalls(), is(6)); assertThat(logger.numCalls(), is(6));
} }
@Test @Test @Ignore("b/222124533")
public void testSwitchProfileLogging() throws InterruptedException { public void testSwitchProfileLogging() throws InterruptedException {
// enable the work tab feature flag // enable the work tab feature flag
ResolverActivity.ENABLE_TABBED_VIEW = true; ResolverActivity.ENABLE_TABBED_VIEW = true;